refactor: simplify scanAllModelCandidates mock parameters in tests#12715
Open
kashish00208 wants to merge 1 commit into
Open
refactor: simplify scanAllModelCandidates mock parameters in tests#12715kashish00208 wants to merge 1 commit into
kashish00208 wants to merge 1 commit into
Conversation
🎨 Storybook:
|
🎭 Playwright: ⏳ Running... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduce duplicated mock function signatures in missingModelPipeline.test.ts by using Parameters<typeof ...> forwarding where type-compatible. This keeps mock wrappers aligned with upstream function signatures and reduces maintenance overhead when APIs change.
Review Focus
I tried applying the pattern to all three mocks. scanAllModelCandidates works, but enrichWithEmbeddedMetadata and verifyAssetSupportedCandidates expose existing type mismatches between the mock signatures and the exported function signatures, resulting in type errors.
Fixes : #11793