refactor(telemetry): route execution events to GTM only (MAR-282)#12717
Merged
Conversation
Remove client-side execution_start/success/error tracking from the Mixpanel and PostHog providers. These events are now emitted solely by the GTM provider, avoiding duplication with the server-side PostHog execution pipeline. Add GTM tests for execution_start and execution_success to pin the remaining client-side path.
🎨 Storybook: ✅ Built — View Storybook |
🎭 Playwright: ✅ 1664 passed, 0 failed · 2 flaky📊 Browser Reports
|
dosubot
Bot
added
the
size:M
Contributor
Author
|
@dante01yoon and @comfyui-wiki it looks like you guys most recently made changes to these files - do you mind taking a look and merging this? funneling the client side execution to only gtm now not mixpanel and posthog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #12717 +/- ##
===========================================
- Coverage 75.23% 61.35% -13.89%
===========================================
Files 1552 1449 -103
Lines 89218 75005 -14213
Branches 24528 21169 -3359
===========================================
- Hits 67126 46021 -21105
- Misses 21340 28630 +7290
+ Partials 752 354 -398
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1185 files with indirect coverage changes 🚀 New features to boost your workflow:
|
benceruleanlu
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Client-side execution events (
execution_start/execution_success/execution_error) are now emitted only by the GTM provider, removing the redundant Mixpanel and PostHog emissions that duplicated the server-side PostHog execution pipeline.Changes
trackWorkflowExecution,trackExecutionError, andtrackExecutionSuccessfromMixpanelTelemetryProviderandPostHogTelemetryProvider, along with the now-unusedlastTriggerSourcefield and related type imports.GtmTelemetryProvider. TheTelemetryProviderinterface declares them optional andTelemetryRegistrydispatches via optional chaining, so callers are unchanged and Mixpanel/PostHog simply receive nothing for these events.execution_startandexecution_success(alongside the existingexecution_errortest) to pin the remaining client-side path.Review Focus
Reference: MAR-282
Prior context: Comfy-Org PR #3423.