[backport cloud/1.44] fix: preserve validation errors on execution start#12731
[backport cloud/1.44] fix: preserve validation errors on execution start#12731jaeone94 wants to merge 2 commits into
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎨 Storybook: ✅ Built — View Storybook |
🎭 Playwright: ✅ 1550 passed, 0 failed · 2 flaky📊 Browser Reports
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.44 #12731 +/- ##
=============================================
Coverage ? 58.92%
=============================================
Files ? 1415
Lines ? 72039
Branches ? 19994
=============================================
Hits ? 42446
Misses ? 29089
Partials ? 504
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
6660255 to
56fd4bc
Compare
Summary
Manual backport of #12493 to
cloud/1.44.Changes
execution_startfires.node_errorsas an object and keep queued job metadata tracking on that response path.queuePrompt()unit regression from fix: preserve validation errors on execution start #12493.Review Focus
This keeps the 1.44
storeJob({ id, nodes, workflow })call shape instead of bringing over the newerpromptOutputjob metadata contract from 1.45/main.Original PR: #12493
Test Plan
pnpm test:coverage src/scripts/app.test.ts src/stores/executionStore.test.tspnpm typecheckpnpm exec oxfmt --check src/scripts/app.test.ts src/scripts/app.ts src/stores/executionErrorStore.ts src/stores/executionStore.ts src/stores/executionStore.test.tspnpm exec oxlint src/scripts/app.test.ts src/scripts/app.ts src/stores/executionErrorStore.ts src/stores/executionStore.ts src/stores/executionStore.test.ts --type-awarepnpm exec eslint --no-warn-ignored src/scripts/app.test.ts src/scripts/app.ts src/stores/executionErrorStore.ts src/stores/executionStore.ts src/stores/executionStore.test.ts