Skip to content

[backport cloud/1.44] fix: preserve validation errors on execution start#12731

Open
jaeone94 wants to merge 2 commits into
cloud/1.44from
codex/backport-12493-cloud-1.44
Open

[backport cloud/1.44] fix: preserve validation errors on execution start#12731
jaeone94 wants to merge 2 commits into
cloud/1.44from
codex/backport-12493-cloud-1.44

Conversation

@jaeone94

@jaeone94 jaeone94 commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

Manual backport of #12493 to cloud/1.44.

Changes

  • What: Preserve validation node errors and the error overlay when execution_start fires.
  • What: Treat successful prompt node_errors as an object and keep queued job metadata tracking on that response path.
  • What: Added the 1.44-adapted queuePrompt() unit regression from fix: preserve validation errors on execution start #12493.
  • Dependencies: None.

Review Focus

This keeps the 1.44 storeJob({ id, nodes, workflow }) call shape instead of bringing over the newer promptOutput job metadata contract from 1.45/main.

Original PR: #12493

Test Plan

  • pnpm test:coverage src/scripts/app.test.ts src/stores/executionStore.test.ts
  • pnpm typecheck
  • pnpm exec oxfmt --check src/scripts/app.test.ts src/scripts/app.ts src/stores/executionErrorStore.ts src/stores/executionStore.ts src/stores/executionStore.test.ts
  • pnpm exec oxlint src/scripts/app.test.ts src/scripts/app.ts src/stores/executionErrorStore.ts src/stores/executionStore.ts src/stores/executionStore.test.ts --type-aware
  • pnpm exec eslint --no-warn-ignored src/scripts/app.test.ts src/scripts/app.ts src/stores/executionErrorStore.ts src/stores/executionStore.ts src/stores/executionStore.test.ts

@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 9, 2026
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 35d5cd36-3fb6-43fd-9622-104aaa49edc3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/backport-12493-cloud-1.44

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 06/09/2026, 01:38:37 PM UTC

Links

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

🎭 Playwright: ✅ 1550 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1531 / ❌ 0 / ⚠️ 2 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 16 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/scripts/app.ts 83.33% 2 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.44   #12731   +/-   ##
=============================================
  Coverage              ?   58.92%           
=============================================
  Files                 ?     1415           
  Lines                 ?    72039           
  Branches              ?    19994           
=============================================
  Hits                  ?    42446           
  Misses                ?    29089           
  Partials              ?      504           
Flag Coverage Δ
unit 58.92% <90.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/stores/executionErrorStore.ts 72.78% <100.00%> (ø)
src/stores/executionStore.ts 85.43% <100.00%> (ø)
src/scripts/app.ts 18.89% <83.33%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaeone94 jaeone94 force-pushed the codex/backport-12493-cloud-1.44 branch from 6660255 to 56fd4bc Compare June 9, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants