Skip to content

fix: add text ticker and tooltip to truncated template text#12733

Draft
pythongosssss wants to merge 2 commits into
mainfrom
pysssss/template-truncated-tooltips
Draft

fix: add text ticker and tooltip to truncated template text#12733
pythongosssss wants to merge 2 commits into
mainfrom
pysssss/template-truncated-tooltips

Conversation

@pythongosssss

Copy link
Copy Markdown
Member

Summary

Changes

  • What:
  • Breaking:
  • Dependencies:

Review Focus

Screenshots (if applicable)

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5819b03f-1758-41ba-a545-ecd99cd276dd

📥 Commits

Reviewing files that changed from the base of the PR and between 1b90696 and 10c17ae.

📒 Files selected for processing (4)
  • browser_tests/tests/templates.spec.ts
  • src/components/custom/widget/WorkflowTemplateSelectorDialog.vue
  • src/composables/useTooltipConfig.test.ts
  • src/composables/useTooltipConfig.ts

📝 Walkthrough

Walkthrough

This PR enhances tooltip behavior and applies the improvements to template cards. The buildTooltipConfig composable now optionally reads tooltip delay from global LiteGraph settings, and the template card selector uses a TextTicker component for long titles while adopting the new tooltip configuration for descriptions.

Changes

Tooltip Enhancement and Template Card Integration

Layer / File(s) Summary
Tooltip configuration with global delay support
src/composables/useTooltipConfig.ts, src/composables/useTooltipConfig.test.ts
Introduces DEFAULT_SHOW_DELAY and TOOLTIP_PT constants; buildTooltipConfig now accepts optional useGlobalDelay parameter that queries LiteGraph.Node.TooltipDelay from settings when enabled, otherwise uses fixed 300ms delay. Vitest tests validate both default and global-delay-enabled configurations.
Template card UI with enhanced tooltips and scrolling titles
src/components/custom/widget/WorkflowTemplateSelectorDialog.vue, browser_tests/tests/templates.spec.ts
Template card title rendering switches to TextTicker component and description tooltip uses v-tooltip.bottom directive with global-delay-enabled config. Imports TextTicker and buildTooltipConfig. Browser test confirms title scrolls on hover and full description appears in tooltip without relying on title attributes.

Sequence Diagram

sequenceDiagram
  participant TemplateCard as Template Card
  participant buildTooltipConfig as buildTooltipConfig()
  participant SettingsStore as SettingsStore
  TemplateCard->>buildTooltipConfig: buildTooltipConfig(description, true)
  alt useGlobalDelay enabled
    buildTooltipConfig->>SettingsStore: get('LiteGraph.Node.TooltipDelay')
    SettingsStore-->>buildTooltipConfig: delay value
    buildTooltipConfig-->>TemplateCard: tooltip config with global delay
  else useGlobalDelay disabled
    buildTooltipConfig-->>TemplateCard: tooltip config with DEFAULT_SHOW_DELAY (300ms)
  end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

size:M, core/1.44, cloud/1.44, core/1.45, cloud/1.45

Suggested reviewers

  • christian-byrne
  • dante01yoon

Poem

A ticker scrolls the template's name so long,
Tooltips dance with delays that sing a song,
Settings whisper their timing to the view—
Cards now gleam with each delay-tuned cue! 🐰✨

🚥 Pre-merge checks | ✅ 6 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is entirely blank except for template placeholders; all required sections (Summary, Changes, Review Focus) lack substantive content. Fill in the Summary section with a one-sentence explanation, provide detailed Changes (What, Breaking, Dependencies), and describe any critical design decisions in the Review Focus section.
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding a text ticker component and tooltip functionality to truncated template text.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed PR includes browser_tests/tests/templates.spec.ts with end-to-end regression test for the template text truncation fix, satisfying the requirement.
Adr Compliance For Entity/Litegraph Changes ✅ Passed PR modifies UI components, composables, and tests only. No changes to src/lib/litegraph/, src/ecs/, or graph entity files; ADR 0003/0008 compliance check does not apply.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch pysssss/template-truncated-tooltips

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

🎭 Playwright: ✅ 1662 passed, 0 failed · 3 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1641 / ❌ 0 / ⚠️ 3 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 06/09/2026, 06:39:25 PM UTC

Links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant