Skip to content

Commit 04c4883

Browse files
committed
Added control for no data case
If the number of items is less than 4 (for example in case of 2), no data is displayed on the metric cards (even if there are versions). This control has been added to the metric cards on the distribution.
1 parent f6f7662 commit 04c4883

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

frontend/express/public/core/platform/templates/platform.html

+4-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ <h4>{{i18n('platforms.platforms-for')}}</h4>
4646
</vue-scroll>
4747
</div>
4848
<h5 class="bu-pb-4"> {{i18n('platforms.version-distribution')}} </h5>
49-
<div v-if="platformVersions.length < 4 && !isLoading" class="technology-analytics-wrapper__versions-empty-card">
49+
<div v-if="platformVersions.length === 0 && !isLoading" class="technology-analytics-wrapper__versions-empty-card">
5050
<div class="text-medium">{{i18n('common.table.no-data')}}</div>
5151
</div>
5252
<div v-else class="technology-analytics-wrapper__versions" v-loading="isLoading">
@@ -60,6 +60,9 @@ <h5 class="bu-pb-4"> {{i18n('platforms.version-distribution')}} </h5>
6060
:scroll-ops="breakdownScrollOps"
6161
v-for="(item, idx) in platformVersions">
6262
</cly-metric-breakdown>
63+
<div v-if="platformItems.length < 4 && !isLoading" class="technology-analytics-wrapper__empty-card">
64+
<div class="text-medium">{{i18n('common.table.no-data')}}</div>
65+
</div>
6366
</cly-metric-cards>
6467
</vue-scroll>
6568
</div>

plugins/browser/frontend/public/templates/browser.html

+4-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ <h4>{{i18n('browser.browser-for')}}</h4>
4747
</vue-scroll>
4848
</div>
4949
<h5 class="bu-pb-4"> {{i18n('browser.version-distribution')}} </h5>
50-
<div v-if="browserVersions.length < 4 && !isLoading" class="technology-analytics-wrapper-browser__versions-empty-card">
50+
<div v-if="browserVersions.length === 0 && !isLoading" class="technology-analytics-wrapper-browser__versions-empty-card">
5151
<div class="text-medium">{{i18n('common.table.no-data')}}</div>
5252
</div>
5353
<div v-else v-loading="isLoading" class="technology-analytics-wrapper-browser__versions">
@@ -61,6 +61,9 @@ <h5 class="bu-pb-4"> {{i18n('browser.version-distribution')}} </h5>
6161
:scroll-ops="breakdownScrollOps"
6262
v-for="(item, idx) in browserVersions">
6363
</cly-metric-breakdown>
64+
<div v-if="browserItems.length < 4 && !isLoading" class="technology-analytics-wrapper-browser__empty-card">
65+
<div class="text-medium">{{i18n('common.table.no-data')}}</div>
66+
</div>
6467
</cly-metric-cards>
6568
</vue-scroll>
6669
</div>

plugins/density/frontend/public/templates/density.html

+4-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ <h4>{{i18n('density.densities-for')}}</h4>
4040
<span class="text-medium">{{item.percentText}}</span>
4141
</template>
4242
</cly-metric-card>
43-
<div v-if="densityItems.length < 4 && !isLoading" class="technology-density-wrapper__empty-card">
43+
<div v-if="densityItems.length === 0 && !isLoading" class="technology-density-wrapper__empty-card">
4444
<div class="text-medium">{{i18n('common.table.no-data')}}</div>
4545
</div>
4646
</cly-metric-cards>
@@ -61,6 +61,9 @@ <h5 class="bu-pb-4"> {{i18n('density.distribution')}} </h5>
6161
:scroll-ops="breakdownScrollOps"
6262
v-for="(item, idx) in densityVersions">
6363
</cly-metric-breakdown>
64+
<div v-if="densityItems.length < 4 && !isLoading" class="technology-density-wrapper__empty-card">
65+
<div class="text-medium">{{i18n('common.table.no-data')}}</div>
66+
</div>
6467
</cly-metric-cards>
6568
</vue-scroll>
6669
</div>

0 commit comments

Comments
 (0)