[container] doing permission validation only in container

Author: ar2rsawseen

frontend/express/public/javascripts/countly/countly.template.js

@@ -816,6 +816,7 @@ var AppRouter = Backbone.Router.extend({
             title: node.text,
             url: node.url,
             icon: node.icon,
+            permission: node.permission,
             node: node
             /*
                 Following secondary params are simply passed to registry, but not directly used for now:
@@ -949,6 +950,7 @@ var AppRouter = Backbone.Router.extend({
             priority: node.priority,
             title: node.text,
             url: node.url,
+            permission: node.permission,
             node: node
             /*
                 Following secondary params are simply passed to registry, but not directly used for now:

frontend/express/public/javascripts/countly/vue/components/sidebar.js

@@ -1,4 +1,4 @@
-/* global app, jQuery, CV, Vue, countlyGlobal, _, Backbone, store, moment, countlyCommon, countlyAuth */
+/* global app, jQuery, CV, Vue, countlyGlobal, _, Backbone, store, moment, countlyCommon */
 
 (function(countlyVue, $) {
 
@@ -71,25 +71,25 @@
         * @param {string} permission - permission name
         * @returns {boolean} - true if permission granted
         **/
-        var checkMenuPermission = function(permission) {
+        /*var checkMenuPermission = function(permission) {
             if (permission) {
                 return countlyAuth.validateRead(permission);
             }
             return countlyAuth.validateGlobalAdmin();
-        };
+        };*/
 
         /**
         * Check feature permission before adding sidebar
         * @memberof app
         * @param {string} permission - permission name
         * @returns {boolean} - true if permission granted
         **/
-        var checkSubMenuPermission = function(permission) {
+        /*var checkSubMenuPermission = function(permission) {
             if (permission) {
                 return countlyAuth.validateRead(permission);
             }
             return countlyAuth.validateGlobalAdmin();
-        };
+        };*/
 
         var AppsMixin = {
             computed: {
@@ -444,7 +444,7 @@
                     }
 
                     var menu = this.menus.filter(function(val) {
-                        if (val.category === "management" && checkSubMenuPermission(val.name)) {
+                        if (val.category === "management") {
                             return true;
                         }
                         return false;

frontend/express/public/javascripts/countly/vue/container.js

@@ -105,9 +105,6 @@
                             if (data && data.permission) {
                                 return countlyAuth.validateRead(data.permission);
                             }
-                            else if (data && data.node && data.node.permission) {
-                                return countlyAuth.validateRead(data.permission);
-                            }
                             return true;
                         });
                     }