Skip to content

Commit 13871d1

Browse files
committed
added "app independent" case to data source filter
1 parent 8314da3 commit 13871d1

File tree

3 files changed

+16
-6
lines changed

3 files changed

+16
-6
lines changed

api/utils/requestProcessor.js

+6-1
Original file line numberDiff line numberDiff line change
@@ -1620,9 +1620,14 @@ const processRequest = (params) => {
16201620
else {
16211621
params.qstring.query.$and.push({"$or": [{"global": {"$ne": false}}, {"creator": params.member._id + ""}]});
16221622
}
1623-
if (params.qstring.app_id) {
1623+
if (params.qstring.app_id && params.qstring.app_id !== "") {
16241624
params.qstring.query.$and.push({"app_id": params.qstring.app_id});
16251625
}
1626+
else if (params.qstring.app_independent === true) {
1627+
console.log(params.qstring.app_independent);
1628+
params.qstring.query.$and.push({"app_id": "undefined"});
1629+
}
1630+
16261631
if (params.qstring.query.$or) {
16271632
params.qstring.query.$and.push({"$or": Object.assign([], params.qstring.query.$or) });
16281633
delete params.qstring.query.$or;

frontend/express/public/core/report-manager/javascripts/countly.views.js

+7-3
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,8 @@
163163
},
164164
availableDataSources: function() {
165165
var obj = {
166-
"all": CV.i18n("report-manager.app-independent")
166+
"all": CV.i18n("report-manager.all-sources"),
167+
"independent": CV.i18n("report-manager.app-independent")
167168
};
168169
if (countlyGlobal.apps && Object.keys(countlyGlobal.apps).length !== 0) {
169170
for (var app in countlyGlobal.apps) {
@@ -173,9 +174,12 @@
173174
return obj;
174175
},
175176
selectedAppId: function() {
176-
return (this.currentFilter.selectedDataSource && this.currentFilter.selectedDataSource !== "all")
177+
return (this.currentFilter.selectedDataSource && !["all", "independent"].includes(this.currentFilter.selectedDataSource))
177178
? this.currentFilter.selectedDataSource
178179
: null;
180+
},
181+
isAppIndependent: function() {
182+
return this.currentFilter.selectedDataSource && this.currentFilter.selectedDataSource === "independent";
179183
}
180184
},
181185
watch: {
@@ -204,6 +208,7 @@
204208
url: countlyCommon.API_PARTS.data.r + "/tasks/list",
205209
data: {
206210
app_id: self.selectedAppId,
211+
app_independent: self.isAppIndependent,
207212
query: JSON.stringify(queryObject),
208213
}
209214
};
@@ -382,7 +387,6 @@
382387
}
383388
else if (command === "download-task") {
384389
self.$emit("download-task", row);
385-
//var link = countlyCommon.API_PARTS.data.r + '/export/download/' + row._id + "?auth_token=" + countlyGlobal.auth_token + "&app_id=" + countlyCommon.ACTIVE_APP_ID;
386390
var app_id = row.type === "dbviewer" ? "" : "&app_id=" + row.app_id + "";
387391
var link = countlyCommon.API_PARTS.data.r + '/export/download/' + row._id + "?auth_token=" + countlyGlobal.auth_token + app_id;
388392
window.location = link;

frontend/express/public/localization/dashboard/dashboard.properties

+3-2
Original file line numberDiff line numberDiff line change
@@ -955,16 +955,17 @@ report-maanger.automatically-created-title = Automatically created Reports
955955
report-manager.all-origins = All Origins
956956
report-manager.all-types = All Types
957957
report-manager.all-statuses = All Statuses
958-
report-manager.all-owners = All owners
958+
report-manager.all-owners = All Owners
959959
report-manager.my-reports = My reports
960+
report-manager.all-sources = All Data Sources
960961
report-manager.data-source = Data source
961962
report-manager.select-data-source = Select data source
962963
report-manager.runtime-type = Runtime type
963964
report-manager.origin = Origin
964965
report-manager.select-origin = Select origin
965966
report-manager.owner = Owner
966967
report-manager.status = Status
967-
report-manager.app-independent = App independent
968+
report-manager.app-independent = App Independent
968969
report-manager.reset-filters = Reset filters
969970
report-manager.filters = Filters
970971

0 commit comments

Comments
 (0)