Skip to content

Commit 154a057

Browse files
authored
Merge pull request #5970 from pnrgenc/star-ratings-drawer-localization-fix
[SER-2121] The Internal Name" and "Add user consent" texts are not correct
2 parents 830a9e8 + 9c906f0 commit 154a057

File tree

4 files changed

+23
-5
lines changed

4 files changed

+23
-5
lines changed

plugins/star-rating/frontend/public/localization/star-rating.properties

+1
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ feedback.selected-pages = On selected pages
115115
feedback.internalName = Internal Name
116116
feedback.internalName.placeholder = Widget Name
117117
feedback.internalName.description = Name survey for internal purposes. It is not going to be shown on survey.
118+
feedback.consent = Add user consent
118119
feedback.question = Question
119120
feedback.rating-symbol = Rating Symbol
120121
feedback.rating-score = Rating Score

plugins/star-rating/frontend/public/stylesheets/ratings.scss

+16
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,22 @@
5454
}
5555
}
5656

57+
&__step {
58+
&__consent-wrapper {
59+
.el-checkbox__label {
60+
padding-left: 8px;
61+
62+
&:hover {
63+
color: #333c48;
64+
}
65+
}
66+
67+
.el-checkbox__input.is-checked + .el-checkbox__label {
68+
color: #333c48;
69+
}
70+
}
71+
}
72+
5773
&__target-page-selector {
5874
width: 100%;
5975
}

plugins/star-rating/frontend/public/templates/drawer.html

+5-4
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@
9898
<cly-form-step id="step1" :name="i18n('feedback.settings')">
9999
<div class="cly-vue-drawer-step__section">
100100
<div class="text-medium text-heading bu-mb-1" data-test-id="ratings-drawer-settings-widget-name-label">
101-
{{i18n('surveys.drawer.internal.name')}}
101+
{{i18n('feedback.internalName')}}
102102
</div>
103103
<div class="text-smallish color-cool-gray-50 bu-mb-1" data-test-id="ratings-drawer-settings-widget-name-desc">
104104
{{i18n('feedback.internalName.description')}}
@@ -178,12 +178,13 @@
178178
<el-input test-id="ratings-drawer-settings-contact-input" v-model="drawerScope.editedObject.popup_email_callout" :placeholder="i18n('feedback.type-your-option-name')"></el-input>
179179
</validation-provider>
180180
</div>
181-
<div class="cly-vue-drawer-step__section bu-py-1 cly-vue-surveys-drawer__consent">
181+
<div class="cly-vue-drawer-step__section bu-py-1 ratings-drawer__step__consent-wrapper">
182182
<el-checkbox
183+
test-id="ratings-drawer-settings-add-user-consent"
183184
class="text-smallish"
184185
@change="onConsentCheckbox(drawerScope.editedObject)"
185186
size="small"
186-
v-bind:label="i18n('surveys.drawer.consent')"
187+
v-bind:label="i18n('feedback.consent')"
187188
v-model="drawerScope.editedObject.consent"
188189
v-if="drawerScope.currentStepId === 'step1'">
189190
</el-checkbox>
@@ -196,7 +197,7 @@
196197
v-model="drawerScope.editedObject.links">
197198
</star-consent-link>
198199
<div class="cly-vue-drawer-step__section">
199-
<div class="text-medium-big cly-vue-surveys-drawer--font-weight-medium bu-pb-2 bu-pt-4">
200+
<div class="text-medium-big bu-has-text-weight-medium bu-pb-2 bu-pt-4">
200201
{{i18n('feedback.buttons.heading')}}
201202
</div>
202203
<div class="text-medium text-heading bu-mb-2" data-test-id="ratings-drawer-settings-button-callout-label">

ui-tests/cypress/lib/dashboard/feedback/ratings/widgets.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ const verifySettingsPageElements = ({
5050

5151
cy.verifyElement({
5252
labelElement: feedbackRatingWidgetsPageElements.WIDGET_NAME_LABEL,
53-
labelText: "surveys.drawer.internal.name",
53+
labelText: "Internal Name",
5454
element: feedbackRatingWidgetsPageElements.WIDGET_NAME_INPUT,
5555
value: widgetName,
5656
elementPlaceHolder: "Widget Name"

0 commit comments

Comments
 (0)