Skip to content

Commit 16e13eb

Browse files
Merge pull request #5617 from Countly/SER-1927
[SER-1927] Create Event Group Button missing from data-manager
2 parents 942ad88 + 7b52459 commit 16e13eb

File tree

2 files changed

+14
-6
lines changed

2 files changed

+14
-6
lines changed

plugins/data-manager/frontend/public/javascripts/countly.views.js

+8
Original file line numberDiff line numberDiff line change
@@ -964,6 +964,14 @@
964964
},
965965
canUserCreateTransform: function() {
966966
return countlyAuth.validateCreate(SUB_FEATURE_TRANSFORMATIONS);
967+
},
968+
showMoreOptions: function() {
969+
return (
970+
(this.isDrill && this.canUserCreateTransform && (this.currentSecondaryTab === 'events' || this.currentSecondaryTab === 'segmentation')) ||
971+
(this.isDrill && this.canUserCreate && this.currentSecondaryTab === 'events') ||
972+
(this.canUserCreate && this.currentSecondaryTab === 'event-groups') ||
973+
(this.isDrill && this.canUserCreateTransform && this.currentSecondaryTab === 'transformations')
974+
);
967975
}
968976
},
969977
components: {

plugins/data-manager/frontend/public/templates/events.html

+6-6
Original file line numberDiff line numberDiff line change
@@ -9,21 +9,21 @@
99
<div v-if="isDrill">
1010
<cly-report-manager-dialog class="bu-mr-2" origin="data-manager"></cly-report-manager-dialog>
1111
</div>
12-
<div v-if="isDrill && currentSecondaryTab !== 'validations'">
13-
<cly-more-options v-if="canUserCreate || canUserCreateTransform" size="small" text="Create new" type="success" icon="el-icon-circle-plus" @command="handleCreateCommand($event, currentSecondaryTab)">
14-
<el-dropdown-item v-if="canUserCreateTransform && (currentSecondaryTab === 'events' || currentSecondaryTab === 'segmentation') " command="create-transform">
12+
<div v-if="currentSecondaryTab !== 'validations'">
13+
<cly-more-options v-if="showMoreOptions" size="small" text="Create new" type="success" icon="el-icon-circle-plus" @command="handleCreateCommand($event, currentSecondaryTab)">
14+
<el-dropdown-item v-if="isDrill && canUserCreateTransform && (currentSecondaryTab === 'events' || currentSecondaryTab === 'segmentation') " command="create-transform">
1515
{{i18n('data-manager.create-transformation')}}
1616
</el-dropdown-item>
17-
<el-dropdown-item v-if="canUserCreate && (currentSecondaryTab === 'events' )" command="create-event">
17+
<el-dropdown-item v-if="isDrill && canUserCreate && (currentSecondaryTab === 'events' )" command="create-event">
1818
{{i18n('data-manager.create-event')}}
1919
</el-dropdown-item>
2020
<el-dropdown-item v-if="canUserCreate && (currentSecondaryTab === 'event-groups') " command="create-event-group">
2121
{{i18n('data-manager.create-group')}}
2222
</el-dropdown-item>
23-
<el-dropdown-item v-if="canUserCreateTransform && (currentSecondaryTab === 'transformations') " command="create-event-transform">
23+
<el-dropdown-item v-if="isDrill && canUserCreateTransform && (currentSecondaryTab === 'transformations') " command="create-event-transform">
2424
{{i18n('data-manager.create-event-transformation')}}
2525
</el-dropdown-item>
26-
<el-dropdown-item v-if="canUserCreateTransform && (currentSecondaryTab === 'transformations') " command="create-segment-transform">
26+
<el-dropdown-item v-if="isDrill && canUserCreateTransform && (currentSecondaryTab === 'transformations') " command="create-segment-transform">
2727
{{i18n('data-manager.create-segment-transformation')}}
2828
</el-dropdown-item>
2929
</cly-more-options>

0 commit comments

Comments
 (0)