Skip to content

Commit 24f755a

Browse files
committed
Merge branch 'master' into release.24.10
# Conflicts: # CHANGELOG.md
2 parents f322798 + c86288e commit 24f755a

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

CHANGELOG.md

+7-1
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,20 @@
1-
## Version 24.10.x
1+
## Version 24.10.4
22
Fixes:
33
- [push] Fixed bug where IOS credentials get mixed up while sending messages from different apps at the same time
44
- [push] Fixed bug where it crashes in connection pool growth because of a type mismatch in an if condition
55

6+
Security:
7+
- [cohorts] Prevent query injection on cohort creation
8+
69
Dependencies:
710
- Bump countly-sdk-nodejs from 22.6.0 to 24.10.0
811
- Bump countly-sdk-web from 24.4.1 to 24.11.0
12+
- Bump express from 4.21.1 to 4.21.2
913
- Bump form-data from 4.0.0 to 4.0.1
1014
- Bump jimp from 0.22.12 to 1.6.0
1115
- Bump jsdoc from 4.0.3 to 4.0.4
16+
- Bump mocha from 10.2.0 to 10.8.2
17+
- Bump mongodb from 4.9.1 to 4.17.2
1218
- Bump nodemailer from 6.9.15 to 6.9.16
1319
- Bump puppeteer from 23.8.0 to 23.9.0
1420
- Bump tslib from 2.7.0 to 2.8.1

plugins/star-rating/api/api.js

+7-1
Original file line numberDiff line numberDiff line change
@@ -722,9 +722,15 @@ function uploadFile(myfile, id, callback) {
722722
if (!changes.targeting) {
723723
changes.targeting = {};
724724
}
725+
if (!changes.targeting.user_segmentation) {
726+
changes.targeting.user_segmentation = '{"query":{},"queryText":""}';
727+
}
728+
if (!changes.targeting.steps) {
729+
changes.targeting.steps = '[]';
730+
}
725731
changes.targeting.app_id = params.app_id + "";//has to be string
726732
// eslint-disable-next-line
727-
createCohort(params, type, widgetId, changes.targeting, function(cohortId) { //create cohort using this
733+
createCohort(params, type, widgetId, changes.targeting, function(cohortId) { //create cohort using this
728734
if (cohortId) {
729735
//update widget record to have this cohortId
730736
common.db.collection("feedback_widgets").findAndModify({ "_id": widgetId }, {}, { $set: { "cohortID": cohortId } }, function(/*err, widget*/) {

0 commit comments

Comments
 (0)