Skip to content

Commit 2aaebb3

Browse files
ar2rsawseenar2rsawseen
authored
Merge pull request #676 from Cookiezaurs/guidelines-frontend-countly
guidelines fixes: data_migration, plugin-upload, frontend/countly
2 parents 4abc18a + bbc010b commit 2aaebb3

21 files changed

+23
-23
lines changed

‎frontend/express/public/javascripts/countly/countly.app.users.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*global countlyCommon, countlyTaskManager */
1+
/*global countlyCommon, countlyTaskManager, jQuery, $*/
22
(function(countlyAppUsers) {
33

44
//export data for user based on passed id

‎frontend/express/public/javascripts/countly/countly.carrier.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*global CountlyHelpers*/
1+
/*global CountlyHelpers, jQuery*/
22
(function() {
33
var _carrierCodeMap = {"46000": "中国移动(GSM)", "46001": "中国联通(GSM)", "46002": "中国移动(TD-S)", "46003": "中国电信(CDMA)", "46005": "中国电信(CDMA)", "46006": "中国联通(WCDMA)", "46007": "中国移动(TD-S)", "46011": "中国电信(FDD-LTE)", "460 11": "中国电信(FDD-LTE)"};
44
/** function returns carrier code name

‎frontend/express/public/javascripts/countly/countly.city.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@
154154

155155
_chart.draw(_dataTable, _chartOptions);
156156
}
157-
157+
158158
/** private method to redraw chart
159159
* @param {object} ob - data for data selection
160160
*/

‎frontend/express/public/javascripts/countly/countly.common.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*global store, countlyGlobal, _, Gauge, d3, moment, countlyTotalUsers*/
1+
/*global store, countlyGlobal, _, Gauge, d3, moment, countlyTotalUsers, jQuery*/
22
/**
33
* Object with common functions to be used for multiple purposes
44
* @name countlyCommon
@@ -667,7 +667,7 @@
667667
* @returns {boolean} true(if not set), else return nothing
668668
*/
669669
var findMinMax = function(index, el) {
670-
// data point is null, this workaround is used to start drawing graph with a certain padding
670+
// data point is null, this workaround is used to start drawing graph with a certain padding
671671
if (!el[1] && parseInt(el[1]) !== 0) {
672672
return true;
673673
}

‎frontend/express/public/javascripts/countly/countly.device.detail.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*global CountlyHelpers, countlyDeviceDetails, countlyAppVersion, countlyCommon, _*/
1+
/*global CountlyHelpers, countlyDeviceDetails, countlyAppVersion, countlyCommon, _, jQuery*/
22
(function() {
33

44
window.countlyDeviceDetails = window.countlyDeviceDetails || {};
@@ -141,7 +141,7 @@
141141
/*var sum = _.reduce(resolutionTotal, function(memo, num) {
142142
return memo + num;
143143
}, 0);*/
144-
var i=0;
144+
var i = 0;
145145
for (i = 0; i < resolutions.length; i++) {
146146
//var percent = (resolutionTotal[i] / sum) * 100;
147147
chartData2[i] = {

‎frontend/express/public/javascripts/countly/countly.device.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*global CountlyHelpers, countlyDeviceList */
1+
/*global CountlyHelpers, countlyDeviceList, jQuery */
22
(function() {
33
/** Function gets full device name
44
* @param {string} shortName - short device name

‎frontend/express/public/javascripts/countly/countly.event.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*global countlyCommon, countlyGlobal, _*/
1+
/*global countlyCommon, countlyGlobal, _, jQuery*/
22
(function(countlyEvent, $, undefined) {
33

44
//Private Properties

‎frontend/express/public/javascripts/countly/countly.helpers.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* global _, countlyGlobal, countlyCommon, app, TableTools, countlyDeviceDetails, moment, $*/
1+
/* global _, countlyGlobal, countlyCommon, app, TableTools, countlyDeviceDetails, moment, jQuery, $*/
22
/*
33
Some helper functions to be used throughout all views. Includes custom
44
popup, alert and confirm dialogs for the time being.

‎frontend/express/public/javascripts/countly/countly.location.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* global countlyCommon, countlyLocation, CountlyHelpers, countlySession, google, _, countlyGlobal, Backbone*/
1+
/* global countlyCommon, countlyLocation, CountlyHelpers, countlySession, google, _, countlyGlobal, Backbone, jQuery, $*/
22
(function() {
33

44
// Private Properties

‎frontend/express/public/javascripts/countly/countly.map.helper.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* global google, _*/
1+
/* global google, _, jQuery*/
22
(function(countlyMapHelper, $) {
33

44
// Private Properties

‎frontend/express/public/javascripts/countly/countly.session.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* global CountlyHelpers, countlySession, countlyLocation, countlyCommon, _*/
1+
/* global CountlyHelpers, countlySession, countlyLocation, countlyCommon, _, jQuery*/
22
(function() {
33

44
window.countlySession = window.countlySession || {};

‎frontend/express/public/javascripts/countly/countly.task.manager.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* global countlyCommon, countlyGlobal, countlyAssistant, CountlyHelpers, store, app*/
1+
/* global countlyCommon, countlyGlobal, countlyAssistant, CountlyHelpers, store, app, jQuery*/
22
(function(countlyTaskManager, $) {
33

44
//Private Properties

‎frontend/express/public/javascripts/countly/countly.template.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* global Backbone, Handlebars, countlyEvent, countlyCommon, countlyGlobal, CountlyHelpers, countlySession, moment, Drop, _, store, countlyLocation*/
1+
/* global Backbone, Handlebars, countlyEvent, countlyCommon, countlyGlobal, CountlyHelpers, countlySession, moment, Drop, _, store, countlyLocation, jQuery, $*/
22
/**
33
* Default Backbone View template from which all countly views should inherit.
44
* A countly view is defined as a page corresponding to a url fragment such

‎frontend/express/public/javascripts/countly/countly.token.manager.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* global countlyCommon, countlyGlobal, */
1+
/* global countlyCommon, countlyGlobal, jQuery*/
22
(function(countlyTokenManager, $) {
33
//we will store our data here
44
var _data = {};

‎frontend/express/public/javascripts/countly/countly.total.users.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* global countlyCommon, countlyGlobal, countlyDevice, _ */
1+
/* global countlyCommon, countlyGlobal, countlyDevice, _, jQuery */
22
(function(countlyTotalUsers, $) {
33

44
//Private Properties

‎frontend/express/public/javascripts/countly/countly.version.history.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* global countlyCommon, countlyGlobal */
1+
/* global countlyCommon, countlyGlobal, jQuery */
22
(function(countlyVersionHistoryManager, $) {
33
//we will store our data here
44
var _data = [];

‎frontend/express/public/javascripts/countly/countly.views.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* global countlyView, countlySession, countlyTotalUsers, countlyCommon, app, CountlyHelpers, countlyGlobal, store, Handlebars, countlyCity, countlyLocation, countlyDevice, countlyDeviceDetails, countlyAppVersion, countlyCarrier, _, countlyEvent, countlyTaskManager, countlyVersionHistoryManager, countlyTokenManager, SessionView, UserView, LoyaltyView, CountriesView, FrequencyView, DeviceView, PlatformView, AppVersionView, CarrierView, ResolutionView, DurationView, ManageAppsView, ManageUsersView, EventsView, DashboardView, EventsBlueprintView, EventsOverviewView, LongTaskView, DownloadView, TokenManagerView, VersionHistoryView, Backbone, pathsToSectionNames, moment, sdks, jstz, getUrls, T*/
1+
/* global countlyView, countlySession, countlyTotalUsers, countlyCommon, app, CountlyHelpers, countlyGlobal, store, Handlebars, countlyCity, countlyLocation, countlyDevice, countlyDeviceDetails, countlyAppVersion, countlyCarrier, _, countlyEvent, countlyTaskManager, countlyVersionHistoryManager, countlyTokenManager, SessionView, UserView, LoyaltyView, CountriesView, FrequencyView, DeviceView, PlatformView, AppVersionView, CarrierView, ResolutionView, DurationView, ManageAppsView, ManageUsersView, EventsView, DashboardView, EventsBlueprintView, EventsOverviewView, LongTaskView, DownloadView, TokenManagerView, VersionHistoryView, Backbone, pathsToSectionNames, moment, sdks, jstz, getUrls, T, jQuery, $*/
22
window.SessionView = countlyView.extend({
33
beforeRender: function() {
44
return $.when(countlySession.initialize(), countlyTotalUsers.initialize("users")).then(function() {});

‎frontend/express/public/javascripts/countly/countly.vue.components.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* global countlyCommon, moment */
1+
/* global countlyCommon, moment, jQuery */
22
(function(CountlyVueComponents, $) {
33

44
/**

‎plugins/data_migration/api/data_migration_helper.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ var cp = require('child_process'); //call process
1010
var spawn = cp.spawn; //for calling comannd line
1111
const os = require('os'); //hostname, eol
1212
const request = require('request');
13-
var common = require('../../../api/utils/common.js');
13+
var common = require('../../../api/utils/common.js');
1414

1515
module.exports = function(my_db) {
1616
var db = "";

‎plugins/data_migration/frontend/public/javascripts/countly.views.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*global countlyCommon, countlyGlobal, CountlyHelpers, jQuery, countlyDataMigration, app, countlyView, Handlebars, Dropzone, ActiveXObject, DataMigrationView*/
1+
/*global countlyCommon, countlyGlobal, CountlyHelpers, jQuery, countlyDataMigration, app, countlyView, Handlebars, Dropzone, ActiveXObject, DataMigrationView, $*/
22
window.DataMigrationView = countlyView.extend({
33
//need to provide at least empty initialize function
44
//to prevent using default template

‎plugins/plugin-upload/frontend/public/javascripts/countly.views.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*global countlyView, production, CountlyHelpers,countlyGlobal, app, Handlebars, Dropzone, countlyCommon */
1+
/*global countlyView, production, CountlyHelpers,countlyGlobal, app, Handlebars, Dropzone, countlyCommon, jQuery, $ */
22
window.PluginUploadView = countlyView.extend({
33

44
//need to provide at least empty initialize function

0 commit comments

Comments
 (0)