Skip to content

Commit 53c14a5

Browse files
committed
[server-1551] lint fixes.
1 parent 6fd30a1 commit 53c14a5

File tree

1 file changed

+19
-13
lines changed

1 file changed

+19
-13
lines changed

frontend/express/public/javascripts/countly/countly.template.js

+19-13
Original file line numberDiff line numberDiff line change
@@ -2650,48 +2650,54 @@ var AppRouter = Backbone.Router.extend({
26502650
return ((x < y) ? 1 : ((x > y) ? -1 : 0));
26512651
};
26522652

2653+
/**
2654+
* Compare two versions
2655+
* @param {String} a, First version
2656+
* @param {String} b, Second version
2657+
* @returns {Number} returns -1, 0 or 1 by result of comparing
2658+
*/
26532659
function compareVersions(a, b) {
26542660
var aParts = a.split('.');
26552661
var bParts = b.split('.');
2656-
2657-
for (var i = 0; i < aParts.length && i < bParts.length; i++) {
2658-
var aPartNum = parseInt(aParts[i], 10);
2659-
var bPartNum = parseInt(bParts[i], 10);
2660-
2662+
2663+
for (var j = 0; j < aParts.length && j < bParts.length; j++) {
2664+
var aPartNum = parseInt(aParts[j], 10);
2665+
var bPartNum = parseInt(bParts[j], 10);
2666+
26612667
var cmp = Math.sign(aPartNum - bPartNum);
2662-
2668+
26632669
if (cmp !== 0) {
26642670
return cmp;
26652671
}
26662672
}
2667-
2673+
26682674
if (aParts.length === bParts.length) {
26692675
return 0;
26702676
}
2671-
2677+
26722678
var longestArray = aParts;
26732679
if (bParts.length > longestArray.length) {
26742680
longestArray = bParts;
26752681
}
2676-
2682+
26772683
var continueIndex = Math.min(aParts.length, bParts.length);
2678-
2684+
26792685
for (var i = continueIndex; i < longestArray.length; i += 1) {
26802686
if (parseInt(longestArray[i], 10) > 0) {
26812687
return longestArray === bParts ? -1 : +1;
26822688
}
26832689
}
2684-
2690+
26852691
return 0;
26862692
}
26872693

26882694
jQuery.fn.dataTableExt.oSort['app_versions-asc'] = function(x, y) {
26892695
return compareVersions(x, y);
2690-
}
2696+
};
26912697

26922698
jQuery.fn.dataTableExt.oSort['app_versions-desc'] = function(x, y) {
26932699
return compareVersions(x, y);
2694-
}
2700+
};
26952701

26962702
jQuery.fn.dataTableExt.oSort['format-ago-asc'] = function(x, y) {
26972703
return x - y;

0 commit comments

Comments
 (0)