[server-1561] lint & ui fixes.

- hasOwnProperty() usage removed.
- hided restricted app collections from dbviewer app filter dropdown too.

Author: frknbasaran

plugins/dbviewer/api/api.js

@@ -252,7 +252,7 @@ var common = require('../../../api/utils/common.js'),
                 //if app_id was provided, we need to check if user has access for this app_id
                 // is user_of array contain current app_id?
                 var isUserOf = params.member.user_of && params.member.user_of.indexOf(params.qstring.app_id) !== -1;
-                var isRestricted = params.member.app_restrict && params.member.app_restrict.hasOwnProperty(params.qstring.app_id) !== -1 && params.member.app_restrict[params.qstring.app_id].indexOf("#/manage/db");
+                var isRestricted = params.member.app_restrict && params.member.app_restrict[params.qstring.app_id] && params.member.app_restrict[params.qstring.app_id].indexOf("#/manage/db");
                 if (params.member.global_admin || isUserOf && !isRestricted) {
                     apps = [params.qstring.app_id];
                 }

plugins/dbviewer/frontend/public/javascripts/countly.views.js

@@ -83,7 +83,9 @@ window.DBViewerView = countlyView.extend({
         $('#app-list').prepend('<div data-value="all" class="app-option item" data-localize=""><span class="app-title-in-dropdown">' + $.i18n.map["common.all"] + '</span></div>');
         // append list items
         for (var key in countlyGlobal.apps) {
-            $('#app-list').append('<div data-value="' + countlyGlobal.apps[key]._id + '" class="app-option item" data-localize=""><span class="app-title-in-dropdown">' + countlyGlobal.apps[key].name + '</span></div>');
+            if (!countlyGlobal.member.app_restrict || (countlyGlobal.member.app_restrict && !countlyGlobal.member.app_restrict.hasOwnProperty(key))) {
+                $('#app-list').append('<div data-value="' + countlyGlobal.apps[key]._id + '" class="app-option item" data-localize=""><span class="app-title-in-dropdown">' + countlyGlobal.apps[key].name + '</span></div>');        
+            }
         }
         // set height 
         if ($('#dbviewer').height() < (window.innerHeight - 150)) {