Skip to content

Commit 6f82d5f

Browse files
committed
[crud-context] plugins, monetization and group related fixes.
1 parent a6a5152 commit 6f82d5f

File tree

5 files changed

+19
-22
lines changed

5 files changed

+19
-22
lines changed

api/utils/requestProcessor.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1293,7 +1293,7 @@ const processRequest = (params) => {
12931293
break;
12941294
case 'permissions':
12951295
validateRead(params, 'core', function() {
1296-
var features = ["core", "events", "global_configurations", "global_plugins", "global_applications", "global_users", "global_jobs"];
1296+
var features = ["core", "events", "global_configurations", "global_applications", "global_users", "global_jobs"];
12971297
plugins.dispatch("/permissions/features", {params: params, features: features}, function() {
12981298
common.returnOutput(params, features);
12991299
});

frontend/express/public/javascripts/countly/countly.auth.js

+6-13
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,8 @@
168168
};
169169

170170
countlyAuth.clearDrawer = function(parent_el, sets) {
171-
$(parent_el + ' #manage-users-admin-app-selector')[0].selectize.setValue([]);
171+
var selector = parent_el.indexOf('group') ? 'groups' : 'users';
172+
$('#manage-' + selector + '-admin-app-selector')[0].selectize.setValue([]);
172173
for (var i = 0; i < sets.length; i++) {
173174
$(parent_el + ' #user-app-selector-' + i)[0].selectize.setValue([]);
174175
}
@@ -199,22 +200,14 @@
199200
permissionObject[accessType][countlyApp] = {};
200201
permissionObject[accessType][countlyApp].all = false;
201202
permissionObject[accessType][countlyApp].allowed = {};
202-
if (accessType === "r") {
203-
permissionObject[accessType][countlyApp].allowed.core = true;
204-
}
205203
permissionObject[accessType].global = {};
206204
permissionObject[accessType].global.all = false;
207205
permissionObject[accessType].global.allowed = {};
208206
}
209207
}
210208

211-
if (permissionSets.length === 0) {
212-
permissionSets.push({c: {all: false, allowed: {}}, r: {all: false, allowed: { core: true }}, u: {all: false, allowed: {}}, d: {all: false, allowed: {}}});
213-
}
214-
else if (permissionSets.length > 0) {
215-
permissionSets = [];
216-
permissionSets.push({c: {all: false, allowed: {}}, r: {all: false, allowed: { core: true }}, u: {all: false, allowed: {}}, d: {all: false, allowed: {}}});
217-
}
209+
permissionSets = [];
210+
permissionSets.push({c: {all: false, allowed: {}}, r: {all: false, allowed: { core: true }}, u: {all: false, allowed: {}}, d: {all: false, allowed: {}}});
218211

219212
return {
220213
permissionObject: permissionObject,
@@ -288,15 +281,15 @@
288281
$('#mark-all-' + countlyAuth.typeNames[j] + '-' + i).countlyCheckbox().set(true);
289282

290283
for (var k = 0; k < countlyAuth.features.length; k++) {
291-
$('#' + countlyAuth.types[j] + '-' + countlyAuth.features[k] + '-' + i).countlyCheckbox().set(true).setDisabled();
284+
$(parent_el + ' #' + countlyAuth.types[j] + '-' + countlyAuth.features[k] + '-' + i).countlyCheckbox().set(true).setDisabled();
292285
}
293286

294287
permission_sets[i][countlyAuth.types[j]].all = true;
295288
}
296289
else {
297290
for (var feature in permission_object[countlyAuth.types[j]][user_apps[i][0]].allowed) {
298291
permission_sets[i] = countlyAuth.giveFeaturePermission(countlyAuth.types[j], feature, permission_sets[i]);
299-
$('#' + countlyAuth.types[j] + '-' + feature + '-' + i).countlyCheckbox().set(true);
292+
$(parent_el + ' #' + countlyAuth.types[j] + '-' + feature + '-' + i).countlyCheckbox().set(true);
300293
}
301294
}
302295
}

frontend/express/public/javascripts/countly/countly.views.js

+11-6
Original file line numberDiff line numberDiff line change
@@ -3377,7 +3377,7 @@ window.ManageUsersView = countlyView.extend({
33773377

33783378
// link checkboxes after dom injection
33793379
for (var i in types) {
3380-
$('#mark-all-' + types[i] + '-' + index).countlyCheckbox();
3380+
$('.create-user-drawer #mark-all-' + types[i] + '-' + index).countlyCheckbox();
33813381
}
33823382

33833383
// jQuery selectize handler for projection input
@@ -3420,7 +3420,7 @@ window.ManageUsersView = countlyView.extend({
34203420
self.features.forEach(function(feature) {
34213421
$('#permission-table-' + index).append(countlyAuth.renderFeatureTemplate(feature, index));
34223422
for (var i in types) {
3423-
$('#' + types[i][0] + '-' + feature + '-' + index).countlyCheckbox();
3423+
$('.create-user-drawer #' + types[i][0] + '-' + feature + '-' + index).countlyCheckbox();
34243424
}
34253425
});
34263426
},
@@ -3680,6 +3680,11 @@ window.ManageUsersView = countlyView.extend({
36803680
$('.create-user-drawer .discard-changes').hide();
36813681
$('#create-user-drawer-title').html($.i18n.map['management-users.create-new-user']);
36823682
$('.create-user-drawer #create-user-button').html($.i18n.map['management-users.create-user']);
3683+
$('.access-area').show();
3684+
$('#sub-header-1th').show();
3685+
$('.add-new-permission-set').show();
3686+
$('.create-user-drawer #manage-users-admin-app-selector')[0].selectize.setValue([]);
3687+
36833688
// clean inputs
36843689
userCreateDrawer.addClass("open");
36853690
userCreateDrawer.find('.full-name-text').val('');
@@ -4036,16 +4041,16 @@ window.ManageUsersView = countlyView.extend({
40364041

40374042
if ($('.create-user-drawer #mark-all-' + type + '-' + index).countlyCheckbox().get()) {
40384043
for (var i = 0; i < self.features.length; i++) {
4039-
$('#' + type.substr(0, 1) + '-' + self.features[i] + '-' + index).countlyCheckbox().set(true);
4040-
$('#' + type.substr(0, 1) + '-' + self.features[i] + '-' + index).countlyCheckbox().setDisabled();
4044+
$('.create-user-drawer #' + type.substr(0, 1) + '-' + self.features[i] + '-' + index).countlyCheckbox().set(true);
4045+
$('.create-user-drawer #' + type.substr(0, 1) + '-' + self.features[i] + '-' + index).countlyCheckbox().setDisabled();
40414046
}
40424047

40434048
self.permissionSets[index] = countlyAuth.updatePermissionByType(type.substr(0, 1), self.permissionSets[index], true);
40444049
}
40454050
else {
40464051
for (var j = 0; j < self.features.length; j++) {
4047-
$('#' + type.substr(0, 1) + '-' + self.features[j] + '-' + index).countlyCheckbox().set(false);
4048-
$('#' + type.substr(0, 1) + '-' + self.features[j] + '-' + index).countlyCheckbox().unsetDisabled();
4052+
$('.create-user-drawer #' + type.substr(0, 1) + '-' + self.features[j] + '-' + index).countlyCheckbox().set(false);
4053+
$('.create-user-drawer #' + type.substr(0, 1) + '-' + self.features[j] + '-' + index).countlyCheckbox().unsetDisabled();
40494054
}
40504055

40514056
self.permissionSets[index] = countlyAuth.updatePermissionByType(type.substr(0, 1), self.permissionSets[index], false);

plugins/plugins/api/api.js

-1
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,6 @@ const FEATURE_NAME = 'global_plugins';
175175
});
176176
});
177177
};
178-
179178
validateRead(params, FEATURE_NAME, function() {
180179
var dir = path.resolve(__dirname, "../../");
181180
walk(dir, function(err, results) {

plugins/video-intelligence-monetization/api/api.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ var common = require('../../../api/utils/common.js'),
55
crypto = require('crypto'),
66
countlyModel = require('../../../api/lib/countly.model.js'),
77
countlyEvents = countlyModel.load("event"),
8-
{ validateRead } = require('../../api/utils/right.js');
8+
{ validateRead } = require('../../../api/utils/rights.js');
99

1010
const FEATURE_NAME = 'monetization';
1111

0 commit comments

Comments
 (0)