Skip to content

Commit a8bdb2a

Browse files
authored
Merge pull request #639 from ArtursKadikis/next
Test optimization. Reduced total test runtime by reducing time in timeouts.
2 parents b9439f9 + 8e630b6 commit a8bdb2a

File tree

20 files changed

+284
-307
lines changed

20 files changed

+284
-307
lines changed

plugins/browser/tests.js

+5-6
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ describe('Testing Browser metrics', function(){
2121
if (err) return done(err);
2222
var ob = JSON.parse(res.text);
2323
ob.should.be.empty;
24-
setTimeout(done, 100)
24+
done();
2525
});
2626
});
2727
});
@@ -35,7 +35,7 @@ describe('Testing Browser metrics', function(){
3535
if (err) return done(err);
3636
var ob = JSON.parse(res.text);
3737
ob.should.have.property('result','Success');
38-
setTimeout(done, 100)
38+
setTimeout(done, 300 * testUtils.testScalingFactor)
3939
});
4040
});
4141
});
@@ -59,15 +59,14 @@ describe('Testing Browser metrics', function(){
5959
{"device_id":DEVICE_ID+"4", "app_key":APP_KEY, "begin_session":1, "metrics":{"_browser": "Firefox"}},
6060
{"device_id":DEVICE_ID+"5", "app_key":APP_KEY, "begin_session":1, "metrics":{"_browser": "IE"}}
6161
];
62-
this.timeout(params.length*10000+10000);
6362
request
6463
.get('/i/bulk?requests='+JSON.stringify(params))
6564
.expect(200)
6665
.end(function(err, res){
6766
if (err) return done(err);
6867
var ob = JSON.parse(res.text);
6968
ob.should.have.property('result', 'Success');
70-
setTimeout(done, params.length*10000)
69+
setTimeout(done, 100 * testUtils.testScalingFactor)
7170
});
7271
});
7372
});
@@ -91,7 +90,7 @@ describe('Testing Browser metrics', function(){
9190
if (err) return done(err);
9291
var ob = JSON.parse(res.text);
9392
ob.should.have.property('result', 'Success');
94-
setTimeout(done, 5000)
93+
setTimeout(done, 10 * testUtils.testScalingFactor)
9594
});
9695
});
9796
});
@@ -104,7 +103,7 @@ describe('Testing Browser metrics', function(){
104103
if (err) return done(err);
105104
var ob = JSON.parse(res.text);
106105
ob.should.be.empty;
107-
setTimeout(done, 100)
106+
done();
108107
});
109108
});
110109
});

0 commit comments

Comments
 (0)