Skip to content

Commit c11e45c

Browse files
committed
[core] improve countly user password change experience
1 parent 8ee40b6 commit c11e45c

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

api/parts/mgmt/users.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -259,8 +259,8 @@ usersApi.createUser = function(params) {
259259

260260
member[0].api_key = common.md5Hash(member[0]._id + (new Date().getTime()));
261261
common.db.collection('members').update({ '_id': member[0]._id }, { $set: { api_key: member[0].api_key } }, function() { });
262-
263-
mail.sendToNewMember(member[0], passwordNoHash);
262+
const escapedHTMLPass = passwordNoHash.replace(/&/g, '&amp;').replace(/</g, '&lt;').replace(/>/g, '&gt;').replace(/"/g, '&quot;');
263+
mail.sendToNewMember(member[0], escapedHTMLPass);
264264
plugins.dispatch("/i/users/create", {
265265
params: params,
266266
data: member[0]

frontend/express/public/javascripts/countly/countly.views.js

+6
Original file line numberDiff line numberDiff line change
@@ -3541,6 +3541,9 @@ window.ManageUsersView = countlyView.extend({
35413541
$("#listof-apps").hide();
35423542
$(".row").removeClass("selected");
35433543
});
3544+
$(".manage-users-table .detail .password-text").off("focus").on("focus", function() {
3545+
$(this).select();
3546+
});
35443547
},
35453548
renderCommon: function() {
35463549
var url = countlyCommon.API_PARTS.users.r + '/all';
@@ -3945,6 +3948,9 @@ window.ManageUsersView = countlyView.extend({
39453948

39463949
$(".change-password").off("click").on('click', function() {
39473950
$(this).parents(".row").next().toggle();
3951+
$(".manage-users-table .detail .password-text").off("focus").on("focus", function() {
3952+
$(this).select();
3953+
});
39483954
});
39493955

39503956
$('body').off('change', '.pp-uploader').on('change', '.pp-uploader', function() {

0 commit comments

Comments
 (0)