Skip to content

Commit ce6190d

Browse files
Merge pull request #5718 from Countly/SER-2112-push-better-error-reporting-for-fcm
[SER-2112] Push: store the error fcm returns even if there's no error mapper
2 parents f5c1065 + 1bf4f2a commit ce6190d

File tree

1 file changed

+9
-2
lines changed
  • plugins/push/api/send/platforms

1 file changed

+9
-2
lines changed

plugins/push/api/send/platforms/a.js

+9-2
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,15 @@ class FCM extends Splitter {
198198
// check if the sdk error is mapped to an internal error.
199199
// set to default if its not.
200200
let internalErrorCode = sdkError?.mapTo ?? ERROR.DATA_PROVIDER;
201-
let internalErrorMessage = sdkError?.message ?? "Invalid error message";
201+
let internalErrorMessage = sdkError?.message;
202+
if (!internalErrorMessage) {
203+
if (error.code && error.message) {
204+
internalErrorMessage = "[" + error.code + "] " + error.message;
205+
}
206+
else {
207+
internalErrorMessage = "Invalid error message";
208+
}
209+
}
202210
errorObject(internalErrorCode, internalErrorMessage)
203211
.addAffected(pushes[i]._id, one);
204212
}
@@ -502,5 +510,4 @@ module.exports = {
502510
fields,
503511
map,
504512
connection: FCM,
505-
506513
};

0 commit comments

Comments
 (0)