Skip to content

Commit d249de5

Browse files
authored
Merge pull request #4830 from Countly/SER-1071-email-reports-remove-the-limitation-on-application-selection-it-is-up-to-4-now
allow any number of selection if maxItems === 0 or is undefined
2 parents 25025d2 + 48e6180 commit d249de5

File tree

2 files changed

+4
-2
lines changed
  • frontend/express/public/javascripts/countly/vue/components
  • plugins/reports/frontend/public/templates

2 files changed

+4
-2
lines changed

frontend/express/public/javascripts/countly/vue/components/input.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -883,7 +883,7 @@
883883
}
884884
},
885885
isItemCountValid: function() {
886-
if (this.mode === "single-list" || this.autoCommit) {
886+
if (this.mode === "single-list" || this.autoCommit || this.maxItems === 0 || this.maxItems === undefined) {
887887
return true;
888888
}
889889
return Array.isArray(this.innerValue) && this.innerValue.length >= this.minItems && this.innerValue.length <= this.maxItems;
@@ -904,6 +904,9 @@
904904
return false;
905905
},
906906
disableNonSelected: function() {
907+
if (this.maxItems === 0 || this.maxItems === undefined) {
908+
return false;
909+
}
907910
return this.innerValue && this.innerValue.length === this.maxItems;
908911
}
909912
},

plugins/reports/frontend/public/templates/vue-main.html

-1
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,6 @@
162162
v-on:change="appsChange"
163163
:collapse-tags="false"
164164
:multiple="true"
165-
:multiple-limit="4"
166165
v-model="drawerScope.editedObject.apps"
167166
multiple>
168167
</cly-app-select>

0 commit comments

Comments
 (0)