[locale] guidelines changes.

- unnecessary variables removed.
- missing jsdoc comments added.
- compare operators changed.
- unnecessary escape operator removed.

Author: frknbasaran

plugins/locale/api/api.js

@@ -1,11 +1,11 @@
-var plugin = {},
+var exported = {},
     langs = require('./utils/langs.js'),
     common = require('../../../api/utils/common.js'),
     fetch = require('../../../api/parts/data/fetch.js'),
     plugins = require('../../pluginManager.js');
 
-(function(plugin) {
-    plugins.register("/worker", function(ob) {
+(function() {
+    plugins.register("/worker", function() {
         common.dbUserMap.locale = 'lo'; // full ISO locale from device
         common.dbUserMap.lang = 'la'; // language extracted from locale
     });
@@ -22,7 +22,7 @@ var plugin = {},
             var locale = params.qstring.metrics._locale, lang = langs.languageFromLocale(locale);
             params.qstring.metrics._lang = lang;
 
-            if (isNewUser || user[common.dbUserMap.locale] != locale) {
+            if (isNewUser || user[common.dbUserMap.locale] !== locale) {
                 userProps[common.dbUserMap.locale] = locale;
             }
         }
@@ -38,7 +38,7 @@ var plugin = {},
     plugins.register("/o", function(ob) {
         var params = ob.params;
         var validateUserForDataReadAPI = ob.validateUserForDataReadAPI;
-        if (params.qstring.method == "langs") {
+        if (params.qstring.method === "langs") {
             validateUserForDataReadAPI(params, fetch.fetchTimeObj, 'langs');
             return true;
         }
@@ -70,6 +70,6 @@ var plugin = {},
         var appId = ob.appId;
         common.db.collection('langs').remove({'_id': {$regex: appId + ".*"}}, function() {});
     });
-}(plugin));
+}(exported));
 
-module.exports = plugin;
+module.exports = exported;

plugins/locale/api/lib/countly.model.js

@@ -1,7 +1,5 @@
 var countlyModel = require('../../../../api/lib/countly.model.js'),
-    countlyCommon = require('../../../../api/lib/countly.common.js'),
-    langs = require('../utils/langs.js'),
-    underscore = require('underscore');
+    langs = require('../utils/langs.js');
 
 var langmap = langs.languages;
 
@@ -10,6 +8,11 @@ var langmap = langs.languages;
 * @module "plugins/locale/api/lib/countly.model"
 * @extends module:api/lib/countly.model~countlyMetric
 */
+
+/**
+* Create model
+* @returns {object} new model
+*/
 function create() {
     var countlyLocales = countlyModel.create(function(code) {
         if (langmap && langmap[code]) {

plugins/locale/api/utils/langs.js

@@ -1,15 +1,15 @@
 'use strict';
 
-var langs = {},
+var exported = {},
     langmap = require('langmap');
 
 (function(langs) {
 
-    var regexp = /[\-_]+/;
+    var regexp = /[-_]+/;
     langs.languageFromLocale = function(locale) {
         var comps = (locale + "").toLowerCase().split(regexp), lang = comps[0];
-        if (lang == 'zh') {
-            if (comps.length != 2) {
+        if (lang === 'zh') {
+            if (comps.length !== 2) {
                 return '';
             }
             else {
@@ -36,6 +36,6 @@ var langs = {},
 
     langs.languages = languages;
 
-}(langs));
+}(exported));
 
-module.exports = langs;
+module.exports = exported;

plugins/locale/frontend/app.js

@@ -1,16 +1,16 @@
-var plugin = {},
+var exported = {},
     countlyConfig = require('../../../frontend/express/config', 'dont-enclose'),
     langs = require('../api/utils/langs.js');
 
 (function(plugin) {
-    plugin.init = function(app, countlyDb) {
+    plugin.init = function(app) {
         app.get(countlyConfig.path + '/dashboard', function(req, res, next) {
             res.expose({
                 languages: langs.languages
             }, 'countlyGlobalLang');
             next();
         });
     };
-}(plugin));
+}(exported));
 
-module.exports = plugin;
+module.exports = exported;

plugins/locale/frontend/public/javascripts/countly.models.js

@@ -1,3 +1,4 @@
+/*global $, jQuery, CountlyHelpers, countlyCommon*/
 (function() {
     var langmap;
     $.ajax({
@@ -10,6 +11,11 @@
         }
     });
 
+    /**
+    * Get language name from language code
+    * @param {string} code - language code
+    * @returns {string} language name
+    */
     function getLanguageName(code) {
         if (langmap && langmap[code]) {
             return langmap[code].englishName;

plugins/locale/frontend/public/javascripts/countly.views.js

@@ -1,3 +1,4 @@
+/*global $, countlyTotalUsers, countlyLanguage, jQuery, app, LanguageView, countlyGlobalLang, Handlebars, countlyView, addDrill, countlyCommon, CountlyHelpers*/
 window.LanguageView = countlyView.extend({
     beforeRender: function() {
         return $.when(countlyLanguage.initialize(), countlyTotalUsers.initialize("languages")).then(function() {});
@@ -68,12 +69,10 @@ window.LanguageView = countlyView.extend({
     refresh: function() {
         var self = this;
         $.when(this.beforeRender()).then(function() {
-            if (app.activeView != self) {
+            if (app.activeView !== self) {
                 return false;
             }
             self.renderCommon(true);
-            newPage = $("<div>" + self.template(self.templateData) + "</div>");
-
             var languageData = countlyLanguage.getData();
             countlyCommon.drawGraph(languageData.chartDPTotal, "#dashboard-graph", "pie");
             countlyCommon.drawGraph(languageData.chartDPNew, "#dashboard-graph2", "pie");
@@ -92,7 +91,7 @@ app.route("/analytics/languages", "languages", function() {
 });
 
 $(document).ready(function() {
-    Handlebars.registerHelper('languageTitle', function(context, options) {
+    Handlebars.registerHelper('languageTitle', function(context) {
         return countlyGlobalLang.languages[context];
     });