[push] Do not return 500 on deletion of a non-existent message

iartem · iartem · commit def192fecdb4 · 2021-05-26T15:19:03.000+03:00
diff --git a/plugins/push/api/parts/endpoints.js b/plugins/push/api/parts/endpoints.js
@@ -1207,7 +1207,7 @@ function cachedData(note) {
             return common.returnMessage(params, 403, 'Only app / global admins are allowed to delete');
         }
 
-        await note.update(common.db, {$bit: {'result.status': {or: N.Status.Deleted}}});
+        await note.update(common.db, {$bit: {'result.status': {or: N.Status.Deleted}}}).catch(log.w.bind(log, 'Error during message deletion'));
         api.cache.remove(_id);
         note.result.status |= N.Status.Deleted;
 

Original file line number	Diff line number	Diff line change
`@@ -1207,7 +1207,7 @@ function cachedData(note) {`
`1207`	`1207`	`return common.returnMessage(params, 403, 'Only app / global admins are allowed to delete');`
`1208`	`1208`	`}`
`1209`	`1209`
`1210`		`- await note.update(common.db, {$bit: {'result.status': {or: N.Status.Deleted}}});`
	`1210`	`+ await note.update(common.db, {$bit: {'result.status': {or: N.Status.Deleted}}}).catch(log.w.bind(log, 'Error during message deletion'));`
`1211`	`1211`	`api.cache.remove(_id);`
`1212`	`1212`	`note.result.status \|= N.Status.Deleted;`
`1213`	`1213`