[push] a combination of bundle, keyid and team is added into hash to prevent collisions for apns credentials

Cihad Tekin · Cihad Tekin · commit ed5737f1aadd · 2024-12-06T14:24:56.000+03:00
diff --git a/plugins/push/api/send/platforms/i.js b/plugins/push/api/send/platforms/i.js
@@ -298,7 +298,8 @@ const CREDS = {
                 return ['Not a private key in P8 format in base64-encoded string'];
             }
 
-            this._data.hash = FORGE.md.sha256.create().update(this._data.key).digest().toHex();
+            const message = this._data.key + this._data.bundle + this._data.keyid + this._data.team;
+            this._data.hash = FORGE.md.sha256.create().update(message).digest().toHex();
         }
 
         /**

Original file line number	Diff line number	Diff line change
`@@ -298,7 +298,8 @@ const CREDS = {`
`298`	`298`	`return ['Not a private key in P8 format in base64-encoded string'];`
`299`	`299`	`}`
`300`	`300`
`301`		`- this._data.hash = FORGE.md.sha256.create().update(this._data.key).digest().toHex();`
	`301`	`+ const message = this._data.key + this._data.bundle + this._data.keyid + this._data.team;`
	`302`	`+ this._data.hash = FORGE.md.sha256.create().update(message).digest().toHex();`
`302`	`303`	`}`
`303`	`304`
`304`	`305`	`/**`