Skip to content

Commit ffd273f

Browse files
committed
[feedback] sdk_version parameter set as optional.
1 parent 04c67aa commit ffd273f

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

plugins/star-rating/frontend/public/templates/feedback-popup.html

+1-2
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,6 @@
168168
var d = new Date();
169169
var h = d.getHours();
170170
var dow = d.getDay();
171-
172171
/*
173172
Get widget configurations for render
174173
*/
@@ -305,7 +304,7 @@
305304
}
306305
$.ajax({
307306
"type": "GET",
308-
"url": url + '/i?events=' + encodeURIComponent(JSON.stringify([eventObject])) + '&app_key=' + app_key + '&device_id=' + device_id + 'sdk_name=' + sdk_name + '&sdk_version=' + sdk_version + '&timestamp=' + Date.now() + '&hour=' + h + '&dow=' + dow + '&app_version=' + app_version,
307+
"url": url + '/i?events=' + encodeURIComponent(JSON.stringify([eventObject])) + '&app_key=' + app_key + '&device_id=' + device_id + 'sdk_name=' + sdk_name + (sdk_version ? '&sdk_version=' + sdk_version : '') + '&timestamp=' + Date.now() + '&hour=' + h + '&dow=' + dow + '&app_version=' + app_version,
309308
"success": function(response) {
310309
document.getElementsByClassName("success-modal-content")[0].style.display = "block";
311310
document.getElementsByClassName("modal-content")[0].style.display = "none";

0 commit comments

Comments
 (0)