node: sort m_dirty_blockindex by block hash

Author: Crypt-iQ

src/node/blockstorage.cpp

@@ -179,6 +179,11 @@ bool CBlockIndexHeightOnlyComparator::operator()(const CBlockIndex* pa, const CB
     return pa->nHeight < pb->nHeight;
 }
 
+bool CBlockIndexBlockHashComparator::operator()(const CBlockIndex* pa, const CBlockIndex* pb) const
+{
+    return UintToArith256(pa->GetBlockHash()) < UintToArith256(pb->GetBlockHash());
+}
+
 std::vector<CBlockIndex*> BlockManager::GetAllBlockIndices()
 {
     AssertLockHeld(cs_main);

src/node/blockstorage.h

@@ -95,6 +95,11 @@ struct CBlockIndexHeightOnlyComparator {
     bool operator()(const CBlockIndex* pa, const CBlockIndex* pb) const;
 };
 
+struct CBlockIndexBlockHashComparator {
+    /* Only used in fuzzing */
+    bool operator()(const CBlockIndex* pa, const CBlockIndex* pb) const;
+};
+
 struct PruneLockInfo {
     int height_first{std::numeric_limits<int>::max()}; //! Height of earliest block that should be kept and not pruned
 };
@@ -238,7 +243,7 @@ class BlockManager
     const Obfuscation m_obfuscation;
 
     /** Dirty block index entries. */
-    std::set<CBlockIndex*> m_dirty_blockindex;
+    std::set<CBlockIndex*, CBlockIndexBlockHashComparator> m_dirty_blockindex;
 
     /** Dirty block file entries. */
     std::set<int> m_dirty_fileinfo;