refactor(*): Test coverage, code improvements.

Author: SepehrHasanabadi

phone_verify/backends/base.py

@@ -57,7 +57,7 @@ def check_security_code_expiry(cls, stored_verification):
         """
         time_difference = timezone.now() - stored_verification.created_at
         if time_difference.seconds > django_settings.PHONE_VERIFICATION.get(
-                "SECURITY_CODE_EXPIRATION_TIME"
+            "SECURITY_CODE_EXPIRATION_TIME"
         ):
             return True
         return False
@@ -127,7 +127,7 @@ def validate_security_code(self, security_code, phone_number, session_token):
 
         # check security_code is not verified
         if stored_verification.is_verified and django_settings.PHONE_VERIFICATION.get(
-                "VERIFY_SECURITY_CODE_ONLY_ONCE"
+            "VERIFY_SECURITY_CODE_ONLY_ONCE"
         ):
             return stored_verification, self.SECURITY_CODE_VERIFIED
 

tests/test_api.py

@@ -23,14 +23,14 @@ def test_phone_registration_sends_message(client, mocker):
     url = reverse("phone-register")
     phone_number = PHONE_NUMBER
     data = {"phone_number": phone_number}
-    api = mocker.patch(
-        "phone_verify.services.PhoneVerificationService.send_verification"
+    twilio_api = mocker.patch(
+        "twilio.rest.Client"
     )
 
     response = client.post(url, data)
 
     assert response.status_code == 200
-    assert api.called
+    assert twilio_api.called
     assert "session_token" in response.data
     sms_verification = apps.get_model("phone_verify", "SMSVerification")
     assert sms_verification.objects.get(
@@ -40,10 +40,13 @@ def test_phone_registration_sends_message(client, mocker):
     settings.DJANGO_SETTINGS["PHONE_VERIFICATION"][
         "BACKEND"
     ] = 'phone_verify.backends.kavenegar.KavenegarBackend'
+    kavenegar_api = mocker.patch(
+        "kavenegar.KavenegarAPI"
+    )
     response = client.post(url, data)
 
     assert response.status_code == 200
-    assert api.called
+    assert kavenegar_api.called
     assert "session_token" in response.data
     sms_verification = apps.get_model("phone_verify", "SMSVerification")
     assert sms_verification.objects.get(

tests/test_settings.py

@@ -21,6 +21,5 @@
         "APP_NAME": "Phone Verify",
         "SECURITY_CODE_EXPIRATION_TIME": 1,  # In seconds only
         "VERIFY_SECURITY_CODE_ONLY_ONCE": False,
-
     },
 }