Skip to content

Missing .ConfigureAwait(false) calls on all awaits, causing deadlocks #134

@marc-costello

Description

@marc-costello

As a library, unless you explicitly need to capture context, every await call should be followed by a ConfigureAwait(false).

Reason being, as a library author, you don't know how this is going to be consumed. For example, in our case, we are throwing the context away earlier on in the process by using .ConfigureAwait(false), prior to calling this library. In turn, this causes a deadlock when we call the async methods in this library, and tasks never complete. This effectively means that we can't use the asynchronous library calls 🤷‍♂️

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions