Link dcmimage privately to libtiff and libpng.

jriesmeier · jriesmeier · commit 6405ca608fca · 2026-01-07T18:19:46.000+01:00
Link dcmimage privately to libtiff and libpng because they are not used by the interface. This avoids unnecessary dependencies. This should fix openSUSE Bug 1254123. Thanks to GitHub user "Vogtinator" for the proposal (see PR #138).
diff --git a/dcmimage/libsrc/CMakeLists.txt b/dcmimage/libsrc/CMakeLists.txt
@@ -24,5 +24,5 @@ DCMTK_ADD_LIBRARY(dcmimage
   diyp2img.cc
 )
 
-DCMTK_TARGET_LINK_MODULES(dcmimage oflog dcmdata dcmimgle)
-DCMTK_TARGET_LINK_LIBRARIES(dcmimage ${LIBTIFF_LIBS} ${LIBPNG_LIBS})
+DCMTK_TARGET_LINK_MODULES(dcmimage PUBLIC oflog dcmdata dcmimgle)
+DCMTK_TARGET_LINK_LIBRARIES(dcmimage PRIVATE ${LIBTIFF_LIBS} ${LIBPNG_LIBS})

Original file line number	Diff line number	Diff line change
`@@ -24,5 +24,5 @@ DCMTK_ADD_LIBRARY(dcmimage`
`24`	`24`	`diyp2img.cc`
`25`	`25`	`)`
`26`	`26`
`27`		`-DCMTK_TARGET_LINK_MODULES(dcmimage oflog dcmdata dcmimgle)`
`28`		`-DCMTK_TARGET_LINK_LIBRARIES(dcmimage ${LIBTIFF_LIBS} ${LIBPNG_LIBS})`
	`27`	`+DCMTK_TARGET_LINK_MODULES(dcmimage PUBLIC oflog dcmdata dcmimgle)`
	`28`	`+DCMTK_TARGET_LINK_LIBRARIES(dcmimage PRIVATE ${LIBTIFF_LIBS} ${LIBPNG_LIBS})`