-
Notifications
You must be signed in to change notification settings - Fork 540
Move away from @ng-dynamic-forms #2216
Copy link
Copy link
Open
Labels
Difficulty: HighEstimated at more than 16 hoursEstimated at more than 16 hourscomponent: submissiondependenciesPull requests that update a dependency filePull requests that update a dependency filehelp wantedNeeds a volunteer to claim to move forwardNeeds a volunteer to claim to move forwardhigh priorityimprovementnew feature
Metadata
Metadata
Assignees
Labels
Difficulty: HighEstimated at more than 16 hoursEstimated at more than 16 hourscomponent: submissiondependenciesPull requests that update a dependency filePull requests that update a dependency filehelp wantedNeeds a volunteer to claim to move forwardNeeds a volunteer to claim to move forwardhigh priorityimprovementnew feature
Type
Projects
Status
📋 To Do
Issue / context
During the Angular 15 upgrade, @Atmire-Kristof noticed conflicts between the newer versions of the following libraries:
ng-bootstrap@ng-dynamic-forms@ng-dynamic-forms/ui-ng-bootstrapstill requiresng-bootstrapv11 as a peer dependency, which itself doesn't support Angular 15ng-bootstrapversions, so this is not a viable workaroundRather than do a half-upgrade we opted to leave both of these libraries as-is for now. This leads to peer dependency mismatch warnings, but everything remains functional.
Solution
It looks like development of
@ng-dynamic-formshas slowed down as of late, and this version mismatch is a bit of a red flag. Therefore, we should consider moving away from this library and use the default Angular forms instead for more stability.This would involve a significant refactor of DSpace Angular submission.
References
Add references/links to any related issues or PRs. These may include:
Related to [Submission Refactor] Refactor Entity Relationships to be modified via WorkspaceItem #858
Left out of Angular 15 upgrade #2204