Remove demo credentials from default landing page

[saiful-semantic]

Describe the bug

A vanilla installation of DSpace Angular displays demo user credentials on the landing page. These credentials are intended for the official demo site but appear in a standard installation where the accounts do not exist.

Displayed content:

The test user accounts below have their password set to the name of this software in lowercase.

    Demo Site Administrator = dspacedemo+admin@gmail.com
    Demo Community Administrator = dspacedemo+commadmin@gmail.com
    Demo Collection Administrator = dspacedemo+colladmin@gmail.com
    Demo Submitter = dspacedemo+submit@gmail.com

This is misleading in a clean install and gives the impression of insecure default credentials.

Observed in: All versions DSpace Angular

---

To Reproduce

1. Perform a standard (vanilla) DSpace backend + Angular UI installation.
2. Start the Angular frontend.
3. Open the landing page.
4. Observe the demo credential block displayed.

---

Expected behavior

A default installation should not display demo credentials.

Demo-specific content should only appear in the official demo environment or behind an explicit demo configuration.

---

Related work

None known.

[guillermo-escire]

Hi @tdonohue and @saiful-semantic , I'm a partner at @jtimal, could you please assign me this issue to work on?

[saiful-semantic]

@guillermo-escire I think it needs consideration of people maintaining the demo site.

In the current setup only demo instance works with the default landing page content and everyone else has to customize it before going live. We need to reverse that arrangement.

[tdonohue]

@saiful-semantic and @guillermo-escire : As the current Demo & Sandbox sites run off of the main and dspace-9_x branches, this change would complicate the demo/sandbox implementation.

The default dspace theme is not meant to be deployed "as-is" in production scenarios, as all of the default homepage text of the dspace theme would be invalid in those scenarios.

That all said, this experience might be improved during the DSpace-CRIS merger, as a new feature will be coming to allow easier editing of the Homepage news from the Admin UI itself. See DSpace/DSpace#11751.

Flagging this as blocked by DSpace/DSpace#11751. In my opinion we shouldn't change default behavior until or after that feature has been ported from DSpace-CRIS. At that time, it may be possible to reconsider the current approach.