Skip to content

Commit c9730e4

Browse files
weymannlsiepel
authored andcommitted
[mercedesme] Add vin automatically to discovered vehicle (openhab#17750)
* add vin as representation property Signed-off-by: Bernd Weymann <[email protected]>
1 parent 304f37d commit c9730e4

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

bundles/org.openhab.binding.mercedesme/src/main/java/org/openhab/binding/mercedesme/internal/discovery/MercedesMeDiscoveryService.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
* associated vehicles and provides DiscoveryResults
3030
*
3131
* @author Bernd Weymann - Initial Contribution
32+
* @author Bernd Weymann - Add vin as representation property
3233
*/
3334
@NonNullByDefault
3435
@Component(service = DiscoveryService.class, configurationPid = "discovery.mercedesme")
@@ -56,8 +57,9 @@ public void vehicleDiscovered(AccountHandler ac, String vin, Map<String, Object>
5657
break;
5758
}
5859
if (ttuid != null) {
60+
properties.put("vin", vin);
5961
thingDiscovered(DiscoveryResultBuilder.create(new ThingUID(ttuid, ac.getThing().getUID(), vin))
60-
.withBridge(ac.getThing().getUID()).withProperties(properties)
62+
.withBridge(ac.getThing().getUID()).withProperties(properties).withRepresentationProperty("vin")
6163
.withLabel("Mercedes Benz " + ttuid.getId().toUpperCase()).build());
6264
}
6365
}

bundles/org.openhab.binding.mercedesme/src/main/java/org/openhab/binding/mercedesme/internal/handler/AccountHandler.java

+3-1
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,9 @@ public void discovery(String vin) {
324324
} else {
325325
if (!capabilitiesMap.containsKey(vin)) {
326326
// only report new discovery if capabilities aren't discovered yet
327-
discoveryService.vehicleDiscovered(this, vin, getCapabilities(vin));
327+
Map<String, Object> discoveryProperties = getCapabilities(vin);
328+
discoveryProperties.put("vin", vin);
329+
discoveryService.vehicleDiscovered(this, vin, discoveryProperties);
328330
}
329331
}
330332
}

0 commit comments

Comments
 (0)