Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New build system. setup.py is being deprecated. #3996

Open
DailyDreaming opened this issue Jan 10, 2022 · 1 comment · May be fixed by #5211
Open

New build system. setup.py is being deprecated. #3996

DailyDreaming opened this issue Jan 10, 2022 · 1 comment · May be fixed by #5211

Comments

@DailyDreaming
Copy link
Member

DailyDreaming commented Jan 10, 2022 •
edited by unito-bot
Loading

Looks like we're going to need a pyproject.toml after all: https://setuptools.pypa.io/en/latest/userguide/quickstart.html

Running setup.py directly will stop working in python3.12 it looks like. They want us to start using python -m build instead for the actual build step. We should update the release process and our readme for users installing from source.

Also good reading: https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html

┆Issue is synchronized with this Jira Task
┆friendlyId: TOIL-1124
@stxue1
Copy link
Contributor

stxue1 commented Feb 12, 2025

While building Toil 8.0.0 in preparation for a release, I got this warning:

DEPRECATION: Legacy editable install of toil[all]==8.0.0 from file:///home/heaucques/Documents/toil_master (setup.py develop) is deprecated. pip 25.0 will enforce this behaviour change. A possible replacement is to add a pyproject.toml or enable --use-pep517, and use setuptools >= 64. If the resulting installation is not behaving as expected, try using --config-settings editable_mode=compat. Please consult the setuptools documentation for more information. Discussion can be found at https://github.com/pypa/pip/issues/11457

I'm using pip 24.2, but pip 25.0 is out now, so we should replace our setup.py soon as the deadline is technically here.

mr-c added a commit that referenced this issue Feb 13, 2025
@mr-c
Add PEP-517 compliance with a minimal pyproject.toml
d0c5659 
Fixes: #3996
@mr-c mr-c linked a pull request Feb 13, 2025 that will close this issue
Open
19 tasks
mr-c added a commit that referenced this issue Feb 13, 2025
@mr-c
Add PEP-517 compliance with a minimal pyproject.toml
d3f7d57 
Fixes: #3996
mr-c added a commit that referenced this issue Feb 13, 2025
@mr-c
Add PEP-517 compliance with a minimal pyproject.toml
ee9eb41 
Fixes: #3996
mr-c added a commit that referenced this issue Feb 13, 2025
@mr-c
Add PEP-517 compliance with a minimal pyproject.toml
4230cab 
Fixes: #3996
mr-c added a commit that referenced this issue Feb 14, 2025
@mr-c
Add PEP-517 compliance with a minimal pyproject.toml
65f9e71 
Fixes: #3996
mr-c added a commit that referenced this issue Feb 14, 2025
@mr-c
Add PEP-517 compliance with a minimal pyproject.toml
fdbe032 
Fixes: #3996
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make tests more independent DataBiosphere/toil
2 participants
@DailyDreaming @stxue1