Skip to content

Commit ec2a07f

Browse files
committed
style(apps): tighten a wordy, PR-number-referencing comment in local-execution.test.ts
Drops the PR reference and a fictional test.skip pointer, keeping the race-condition mechanism and what running the test live actually proves.
1 parent 54c6843 commit ec2a07f

1 file changed

Lines changed: 5 additions & 6 deletions

File tree

packages/plugins/apps/src/vite/local-execution.test.ts

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -607,12 +607,11 @@ describe('local-execution — executeScriptLocally', () => {
607607
// every call. Without the `enqueue` queue, two concurrent calls both
608608
// write it synchronously before either yields, so the second write
609609
// wins for the whole duration of both calls and the first call's
610-
// customer code ends up reading the second call's args — see the
611-
// `test.skip`'d version of this same test against PR #479's
612-
// un-serialized base, which fails with exactly that cross-
613-
// contamination. Running it live here, through the real serialized
614-
// `executeScriptLocally` entrypoint, proves the queue actually closes
615-
// the gap rather than just changing the ordering of interleaved work.
610+
// customer code ends up reading the second call's args. Running this
611+
// live through the real serialized `executeScriptLocally` entrypoint
612+
// (not a hand-rolled ordering assertion) proves the queue actually
613+
// closes that gap rather than just changing the ordering of
614+
// interleaved work.
616615
test("Should let each concurrent call see its OWN backendFunctionArgs via globalThis.$, not the other call's", async () => {
617616
const [resultA, resultB] = await Promise.all([
618617
executeScriptLocally(

0 commit comments

Comments
 (0)