Avoid NPE setting null on optional lists

Author: ddadamhooper

.generator/src/generator/templates/modelSimple.j2

@@ -120,12 +120,18 @@ public class {{ name }} {%- if model.get("x-generate-alias-as-model") %} extends
     {%- else %}
     {%- if schema.get("items")|is_model and not schema|is_primitive %}
     {%- set itemsDataType = get_type(schema.get("items")) %}
+    {%- if not isRequired %}
+    if ({{ variableName }} != null) {
+    {%- endif %}
     for ({{ itemsDataType }} item : {{ variableName }}) {
       {%- if schema.enum is defined %}
       this.unparsed |= !item.isValid();
       {%- endif %}
       this.unparsed |= item.unparsed;
     }
+    {%- if not isRequired %}
+    }
+    {%- endif %}
     {%- endif %}
     {%- endif %}
     {%- endif %}

src/main/java/com/datadog/api/client/v1/model/AWSAccountListResponse.java

@@ -29,8 +29,10 @@ public class AWSAccountListResponse {
 
   public AWSAccountListResponse accounts(List<AWSAccount> accounts) {
     this.accounts = accounts;
-    for (AWSAccount item : accounts) {
-      this.unparsed |= item.unparsed;
+    if (accounts != null) {
+      for (AWSAccount item : accounts) {
+        this.unparsed |= item.unparsed;
+      }
     }
     return this;
   }

src/main/java/com/datadog/api/client/v1/model/AWSEventBridgeAccountConfiguration.java

@@ -60,8 +60,10 @@ public void setAccountId(String accountId) {
 
   public AWSEventBridgeAccountConfiguration eventHubs(List<AWSEventBridgeSource> eventHubs) {
     this.eventHubs = eventHubs;
-    for (AWSEventBridgeSource item : eventHubs) {
-      this.unparsed |= item.unparsed;
+    if (eventHubs != null) {
+      for (AWSEventBridgeSource item : eventHubs) {
+        this.unparsed |= item.unparsed;
+      }
     }
     return this;
   }

src/main/java/com/datadog/api/client/v1/model/AWSEventBridgeListResponse.java

@@ -35,8 +35,10 @@ public class AWSEventBridgeListResponse {
 
   public AWSEventBridgeListResponse accounts(List<AWSEventBridgeAccountConfiguration> accounts) {
     this.accounts = accounts;
-    for (AWSEventBridgeAccountConfiguration item : accounts) {
-      this.unparsed |= item.unparsed;
+    if (accounts != null) {
+      for (AWSEventBridgeAccountConfiguration item : accounts) {
+        this.unparsed |= item.unparsed;
+      }
     }
     return this;
   }

src/main/java/com/datadog/api/client/v1/model/AWSLogsAsyncResponse.java

@@ -35,8 +35,10 @@ public class AWSLogsAsyncResponse {
 
   public AWSLogsAsyncResponse errors(List<AWSLogsAsyncError> errors) {
     this.errors = errors;
-    for (AWSLogsAsyncError item : errors) {
-      this.unparsed |= item.unparsed;
+    if (errors != null) {
+      for (AWSLogsAsyncError item : errors) {
+        this.unparsed |= item.unparsed;
+      }
     }
     return this;
   }

src/main/java/com/datadog/api/client/v1/model/AWSLogsListResponse.java

@@ -60,8 +60,10 @@ public void setAccountId(String accountId) {
 
   public AWSLogsListResponse lambdas(List<AWSLogsLambda> lambdas) {
     this.lambdas = lambdas;
-    for (AWSLogsLambda item : lambdas) {
-      this.unparsed |= item.unparsed;
+    if (lambdas != null) {
+      for (AWSLogsLambda item : lambdas) {
+        this.unparsed |= item.unparsed;
+      }
     }
     return this;
   }

src/main/java/com/datadog/api/client/v1/model/AWSTagFilterListResponse.java

@@ -29,8 +29,10 @@ public class AWSTagFilterListResponse {
 
   public AWSTagFilterListResponse filters(List<AWSTagFilter> filters) {
     this.filters = filters;
-    for (AWSTagFilter item : filters) {
-      this.unparsed |= item.unparsed;
+    if (filters != null) {
+      for (AWSTagFilter item : filters) {
+        this.unparsed |= item.unparsed;
+      }
     }
     return this;
   }

src/main/java/com/datadog/api/client/v1/model/ApiKeyListResponse.java

@@ -29,8 +29,10 @@ public class ApiKeyListResponse {
 
   public ApiKeyListResponse apiKeys(List<ApiKey> apiKeys) {
     this.apiKeys = apiKeys;
-    for (ApiKey item : apiKeys) {
-      this.unparsed |= item.unparsed;
+    if (apiKeys != null) {
+      for (ApiKey item : apiKeys) {
+        this.unparsed |= item.unparsed;
+      }
     }
     return this;
   }

src/main/java/com/datadog/api/client/v1/model/ApmStatsQueryDefinition.java

@@ -73,8 +73,10 @@ public ApmStatsQueryDefinition(
 
   public ApmStatsQueryDefinition columns(List<ApmStatsQueryColumnType> columns) {
     this.columns = columns;
-    for (ApmStatsQueryColumnType item : columns) {
-      this.unparsed |= item.unparsed;
+    if (columns != null) {
+      for (ApmStatsQueryColumnType item : columns) {
+        this.unparsed |= item.unparsed;
+      }
     }
     return this;
   }

src/main/java/com/datadog/api/client/v1/model/ApplicationKeyListResponse.java

@@ -29,8 +29,10 @@ public class ApplicationKeyListResponse {
 
   public ApplicationKeyListResponse applicationKeys(List<ApplicationKey> applicationKeys) {
     this.applicationKeys = applicationKeys;
-    for (ApplicationKey item : applicationKeys) {
-      this.unparsed |= item.unparsed;
+    if (applicationKeys != null) {
+      for (ApplicationKey item : applicationKeys) {
+        this.unparsed |= item.unparsed;
+      }
     }
     return this;
   }