Skip to content

Commit f4095ab

Browse files
authored
Revert "Revert "Build binaries with otlp enabled. (#114)" (#115)" (#125)
This reverts commit ff5c8ff.
1 parent 7aefa5e commit f4095ab

File tree

5 files changed

+15
-8
lines changed

5 files changed

+15
-8
lines changed

scripts/Dockerfile.alpine.build

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ FROM alpine:3.16 as builder
44
ARG EXTENSION_VERSION
55
ARG AGENT_VERSION
66
ARG CMD_PATH
7+
ARG BUILD_TAGS
78

89
RUN apk add --no-cache git make musl-dev go gcc
910
ENV GOROOT /usr/lib/go
@@ -30,12 +31,12 @@ RUN --mount=type=cache,target=/go/pkg/mod \
3031
if [ -z "$AGENT_VERSION" ]; then \
3132
go build -ldflags="-w \
3233
-X github.com/DataDog/datadog-agent/pkg/serverless/tags.currentExtensionVersion=$EXTENSION_VERSION" \
33-
-tags serverless -o datadog-agent; \
34+
-tags "${BUILD_TAGS}" -o datadog-agent; \
3435
else \
3536
go build -ldflags="-w \
3637
-X github.com/DataDog/datadog-agent/pkg/serverless/tags.currentExtensionVersion=$EXTENSION_VERSION \
3738
-X github.com/DataDog/datadog-agent/pkg/version.agentVersionDefault=$AGENT_VERSION" \
38-
-tags serverless -o datadog-agent; \
39+
-tags "${BUILD_TAGS}" -o datadog-agent; \
3940
fi
4041

4142
RUN go tool nm datadog-agent | grep -w 'github.com/DataDog/datadog-agent/pkg/version.agentVersionDefault' || \

scripts/Dockerfile.build

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ FROM golang:1.19 as builder
44
ARG EXTENSION_VERSION
55
ARG AGENT_VERSION
66
ARG CMD_PATH
7+
ARG BUILD_TAGS
78
RUN mkdir -p /tmp/dd/datadog-agent
89

910
# cache dependencies
@@ -23,12 +24,12 @@ RUN --mount=type=cache,target=/go/pkg/mod \
2324
if [ -z "$AGENT_VERSION" ]; then \
2425
go build -ldflags="-w \
2526
-X github.com/DataDog/datadog-agent/pkg/serverless/tags.currentExtensionVersion=$EXTENSION_VERSION" \
26-
-tags serverless -o datadog-agent; \
27+
-tags "${BUILD_TAGS}" -o datadog-agent; \
2728
else \
2829
go build -ldflags="-w \
2930
-X github.com/DataDog/datadog-agent/pkg/serverless/tags.currentExtensionVersion=$EXTENSION_VERSION \
3031
-X github.com/DataDog/datadog-agent/pkg/version.agentVersionDefault=$AGENT_VERSION" \
31-
-tags serverless -o datadog-agent; \
32+
-tags "${BUILD_TAGS}" -o datadog-agent; \
3233
fi
3334

3435
RUN go tool nm datadog-agent | grep -w 'github.com/DataDog/datadog-agent/pkg/version.agentVersionDefault' || \

scripts/Dockerfile.race.build

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ FROM golang:1.19 as builder
44
ARG EXTENSION_VERSION
55
ARG ENABLE_RACE_DETECTION
66
ARG AGENT_VERSION
7+
ARG BUILD_TAGS
78
RUN mkdir -p /tmp/dd/datadog-agent
89

910
# cache dependsencies
@@ -23,12 +24,12 @@ RUN --mount=type=cache,target=/go/pkg/mod \
2324
if [ -z "$AGENT_VERSION" ]; then \
2425
go build -race -ldflags="-w \
2526
-X github.com/DataDog/datadog-agent/pkg/serverless/tags.currentExtensionVersion=$EXTENSION_VERSION" \
26-
-tags serverless -o datadog-agent; \
27+
-tags "${BUILD_TAGS}" -o datadog-agent; \
2728
else \
2829
go build -race -ldflags="-w \
2930
-X github.com/DataDog/datadog-agent/pkg/serverless/tags.currentExtensionVersion=$EXTENSION_VERSION \
3031
-X github.com/DataDog/datadog-agent/pkg/version.agentVersionDefault=$AGENT_VERSION" \
31-
-tags serverless -o datadog-agent; \
32+
-tags "${BUILD_TAGS}" -o datadog-agent; \
3233
fi
3334

3435
RUN go tool nm datadog-agent | grep -w 'github.com/DataDog/datadog-agent/pkg/version.agentVersionDefault' || \

scripts/build_binary_and_layer_dockerized.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,10 @@ fi
2121

2222
if [ -z "$CLOUD_RUN" ]; then
2323
CMD_PATH="cmd/serverless"
24+
BUILD_TAGS="serverless otlp"
2425
else
2526
CMD_PATH="cmd/serverless-init"
27+
BUILD_TAGS="serverless"
2628
fi
2729

2830
AGENT_PATH="../datadog-agent"
@@ -68,6 +70,7 @@ function docker_build_zip {
6870
--build-arg EXTENSION_VERSION="${VERSION}" \
6971
--build-arg AGENT_VERSION="${AGENT_VERSION}" \
7072
--build-arg CMD_PATH="${CMD_PATH}" \
73+
--build-arg BUILD_TAGS="${BUILD_TAGS}" \
7174
. --load
7275
dockerId=$(docker create datadog/build-lambda-extension-${arch}:$VERSION)
7376
docker cp $dockerId:/datadog_extension.zip $TARGET_DIR/datadog_extension-${arch}${suffix}.zip

scripts_v2/Dockerfile.build

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ FROM golang:1.19 as builder
44
ARG EXTENSION_VERSION
55
ARG AGENT_VERSION
66
ARG CMD_PATH
7+
ARG BUILD_TAGS
78

89
RUN mkdir -p /tmp/dd
910

@@ -18,12 +19,12 @@ RUN --mount=type=cache,target=/go/pkg/mod \
1819
if [ -z "$AGENT_VERSION" ]; then \
1920
go build -ldflags="-w \
2021
-X github.com/DataDog/datadog-agent/pkg/serverless/tags.currentExtensionVersion=$EXTENSION_VERSION" \
21-
-tags serverless -o datadog-agent; \
22+
-tags "${BUILD_TAGS}" -o datadog-agent; \
2223
else \
2324
go build -ldflags="-w \
2425
-X github.com/DataDog/datadog-agent/pkg/serverless/tags.currentExtensionVersion=$EXTENSION_VERSION \
2526
-X github.com/DataDog/datadog-agent/pkg/version.agentVersionDefault=$AGENT_VERSION" \
26-
-tags serverless -o datadog-agent; \
27+
-tags "${BUILD_TAGS}" -o datadog-agent; \
2728
fi
2829

2930
RUN go tool nm datadog-agent | grep -w 'github.com/DataDog/datadog-agent/pkg/version.agentVersionDefault' || \

0 commit comments

Comments
 (0)