Skip to content

Conversation

@rachelyangdog
Copy link
Contributor

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@rachelyangdog rachelyangdog requested a review from a team as a code owner October 22, 2025 18:34
@rachelyangdog rachelyangdog marked this pull request as draft October 22, 2025 18:34
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.15%. Comparing base (1fa51af) to head (8fd2dca).
⚠️ Report is 25 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3460      +/-   ##
==========================================
- Coverage   62.19%   62.15%   -0.04%     
==========================================
  Files         141      141              
  Lines       12622    12622              
  Branches     1650     1650              
==========================================
- Hits         7850     7845       -5     
- Misses       4045     4050       +5     
  Partials      727      727              

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fa51af...8fd2dca. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Oct 22, 2025

Benchmarks [ tracer ]

Benchmark execution time: 2025-11-04 21:51:07

Comparing candidate commit 06ac1e0 in PR branch rachel.yang/otel-metrics-part1 with baseline commit 1fa51af in branch master.

Found 3 performance improvements and 4 performance regressions! Performance is the same for 186 metrics, 1 unstable metrics.

scenario:EmptyFileBench/benchEmptyFileDdprof-opcache

  • 🟥 execution_time [+173.529µs; +341.791µs] or [+4.725%; +9.306%]

scenario:LogsInjectionBench/benchLogsInfoBaseline-opcache

  • 🟩 execution_time [-80.937ns; -55.863ns] or [-4.512%; -3.114%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟥 execution_time [+6.178µs; +7.602µs] or [+5.867%; +7.218%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟥 execution_time [+3.875µs; +5.365µs] or [+3.666%; +5.075%]

scenario:SamplingRuleMatchingBench/benchGlobMatching1-opcache

  • 🟩 execution_time [-173.301ns; -55.899ns] or [-7.250%; -2.338%]

scenario:SymfonyBench/benchSymfonyDdprof-opcache

  • 🟥 execution_time [+193.087µs; +298.953µs] or [+2.281%; +3.532%]

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟩 execution_time [-30.369µs; -17.131µs] or [-6.908%; -3.897%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants