-
Notifications
You must be signed in to change notification settings - Fork 469
chore(profiling): improve typing in memalloc.py
#15500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(profiling): improve typing in memalloc.py
#15500
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 249 ± 4 ms. The average import time from base is: 251 ± 2 ms. The import time difference between this PR and base is: -2.8 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
memalloc.py
56c8412 to
1dd21ff
Compare
Performance SLOsComparing candidate kowalski/chore-profiling-improve-typing-in-memalloc-py (1dd21ff) with baseline main (874de50) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.404µs (SLO: <10.000µs 📉 -96.0%) vs baseline: ~same Memory: ✅ 40.305MB (SLO: <41.500MB -2.9%) vs baseline: +4.1% ✅ add_inplace_aspectTime: ✅ 0.406µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -0.2% Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +3.9% ✅ add_inplace_noaspectTime: ✅ 0.320µs (SLO: <10.000µs 📉 -96.8%) vs baseline: -1.3% Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +3.9% ✅ add_noaspectTime: ✅ 0.278µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -0.2% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +4.5% ✅ bytearray_aspectTime: ✅ 1.356µs (SLO: <10.000µs 📉 -86.4%) vs baseline: +0.7% Memory: ✅ 40.108MB (SLO: <41.500MB -3.4%) vs baseline: +4.4% ✅ bytearray_extend_aspectTime: ✅ 1.493µs (SLO: <10.000µs 📉 -85.1%) vs baseline: -1.2% Memory: ✅ 40.344MB (SLO: <41.500MB -2.8%) vs baseline: +4.2% ✅ bytearray_extend_noaspectTime: ✅ 0.616µs (SLO: <10.000µs 📉 -93.8%) vs baseline: +0.8% Memory: ✅ 40.285MB (SLO: <41.500MB -2.9%) vs baseline: +3.8% ✅ bytearray_noaspectTime: ✅ 0.495µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +1.8% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +3.7% ✅ bytes_aspectTime: ✅ 1.294µs (SLO: <10.000µs 📉 -87.1%) vs baseline: -0.2% Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +3.9% ✅ bytes_noaspectTime: ✅ 0.494µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.6% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +4.7% ✅ bytesio_aspectTime: ✅ 1.341µs (SLO: <10.000µs 📉 -86.6%) vs baseline: +1.6% Memory: ✅ 40.108MB (SLO: <41.500MB -3.4%) vs baseline: +4.3% ✅ bytesio_noaspectTime: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.8% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +4.7% ✅ capitalize_aspectTime: ✅ 0.735µs (SLO: <10.000µs 📉 -92.7%) vs baseline: +0.1% Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +4.8% ✅ capitalize_noaspectTime: ✅ 0.429µs (SLO: <10.000µs 📉 -95.7%) vs baseline: -0.9% Memory: ✅ 40.128MB (SLO: <41.500MB -3.3%) vs baseline: +3.7% ✅ casefold_aspectTime: ✅ 0.734µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.4% Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +4.9% ✅ casefold_noaspectTime: ✅ 0.368µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.7% Memory: ✅ 40.069MB (SLO: <41.500MB -3.4%) vs baseline: +4.3% ✅ decode_aspectTime: ✅ 0.719µs (SLO: <10.000µs 📉 -92.8%) vs baseline: -1.0% Memory: ✅ 40.383MB (SLO: <41.500MB -2.7%) vs baseline: +4.5% ✅ decode_noaspectTime: ✅ 0.420µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +0.5% Memory: ✅ 40.088MB (SLO: <41.500MB -3.4%) vs baseline: +4.6% ✅ encode_aspectTime: ✅ 0.712µs (SLO: <10.000µs 📉 -92.9%) vs baseline: -0.1% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +4.2% ✅ encode_noaspectTime: ✅ 0.400µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -2.0% Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +4.8% ✅ format_aspectTime: ✅ 3.425µs (SLO: <10.000µs 📉 -65.7%) vs baseline: -0.6% Memory: ✅ 40.128MB (SLO: <41.500MB -3.3%) vs baseline: +3.7% ✅ format_map_aspectTime: ✅ 3.558µs (SLO: <10.000µs 📉 -64.4%) vs baseline: -0.9% Memory: ✅ 40.128MB (SLO: <41.500MB -3.3%) vs baseline: +4.7% ✅ format_map_noaspectTime: ✅ 0.782µs (SLO: <10.000µs 📉 -92.2%) vs baseline: +0.9% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +4.3% ✅ format_noaspectTime: ✅ 0.594µs (SLO: <10.000µs 📉 -94.1%) vs baseline: ~same Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +4.3% ✅ index_aspectTime: ✅ 0.360µs (SLO: <10.000µs 📉 -96.4%) vs baseline: +1.1% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +4.2% ✅ index_noaspectTime: ✅ 0.281µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +1.5% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +4.2% ✅ join_aspectTime: ✅ 1.333µs (SLO: <10.000µs 📉 -86.7%) vs baseline: -1.3% Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +4.3% ✅ join_noaspectTime: ✅ 0.497µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +1.8% Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +4.2% ✅ ljust_aspectTime: ✅ 2.621µs (SLO: <20.000µs 📉 -86.9%) vs baseline: +2.0% Memory: ✅ 40.442MB (SLO: <41.500MB -2.5%) vs baseline: +5.5% ✅ ljust_noaspectTime: ✅ 0.405µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.1% Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +4.7% ✅ lower_aspectTime: ✅ 2.290µs (SLO: <10.000µs 📉 -77.1%) vs baseline: +2.0% Memory: ✅ 40.305MB (SLO: <41.500MB -2.9%) vs baseline: +4.9% ✅ lower_noaspectTime: ✅ 0.370µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.2% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +4.7% ✅ lstrip_aspectTime: ✅ 2.258µs (SLO: <20.000µs 📉 -88.7%) vs baseline: +0.8% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +3.8% ✅ lstrip_noaspectTime: ✅ 0.382µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.3% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +4.9% ✅ modulo_aspectTime: ✅ 1.039µs (SLO: <10.000µs 📉 -89.6%) vs baseline: +3.9% Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +3.9% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.540µs (SLO: <10.000µs 📉 -84.6%) vs baseline: -0.9% Memory: ✅ 40.324MB (SLO: <41.500MB -2.8%) vs baseline: +5.1% ✅ modulo_aspect_for_bytesTime: ✅ 0.981µs (SLO: <10.000µs 📉 -90.2%) vs baseline: +1.5% Memory: ✅ 40.324MB (SLO: <41.500MB -2.8%) vs baseline: +5.2% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.252µs (SLO: <10.000µs 📉 -87.5%) vs baseline: +3.1% Memory: ✅ 40.128MB (SLO: <41.500MB -3.3%) vs baseline: +4.7% ✅ modulo_noaspectTime: ✅ 0.623µs (SLO: <10.000µs 📉 -93.8%) vs baseline: -0.2% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +4.7% ✅ replace_aspectTime: ✅ 4.848µs (SLO: <10.000µs 📉 -51.5%) vs baseline: -2.2% Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +4.8% ✅ replace_noaspectTime: ✅ 0.461µs (SLO: <10.000µs 📉 -95.4%) vs baseline: +0.3% Memory: ✅ 40.285MB (SLO: <41.500MB -2.9%) vs baseline: +4.9% ✅ repr_aspectTime: ✅ 0.904µs (SLO: <10.000µs 📉 -91.0%) vs baseline: -0.3% Memory: ✅ 40.324MB (SLO: <41.500MB -2.8%) vs baseline: +4.5% ✅ repr_noaspectTime: ✅ 0.416µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -1.4% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +4.3% ✅ rstrip_aspectTime: ✅ 1.927µs (SLO: <20.000µs 📉 -90.4%) vs baseline: +0.9% Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +3.6% ✅ rstrip_noaspectTime: ✅ 0.380µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.5% Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +4.9% ✅ slice_aspectTime: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.3% Memory: ✅ 40.108MB (SLO: <41.500MB -3.4%) vs baseline: +3.8% ✅ slice_noaspectTime: ✅ 0.446µs (SLO: <10.000µs 📉 -95.5%) vs baseline: +0.2% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +4.8% ✅ stringio_aspectTime: ✅ 1.549µs (SLO: <10.000µs 📉 -84.5%) vs baseline: +1.3% Memory: ✅ 40.324MB (SLO: <41.500MB -2.8%) vs baseline: +5.1% ✅ stringio_noaspectTime: ✅ 0.717µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +0.4% Memory: ✅ 40.147MB (SLO: <41.500MB -3.3%) vs baseline: +4.5% ✅ strip_aspectTime: ✅ 2.250µs (SLO: <20.000µs 📉 -88.8%) vs baseline: +1.5% Memory: ✅ 40.442MB (SLO: <41.500MB -2.5%) vs baseline: +5.1% ✅ strip_noaspectTime: ✅ 0.383µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -1.0% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +4.9% ✅ swapcase_aspectTime: ✅ 2.811µs (SLO: <10.000µs 📉 -71.9%) vs baseline: 📈 +14.7% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +4.9% ✅ swapcase_noaspectTime: ✅ 0.535µs (SLO: <10.000µs 📉 -94.7%) vs baseline: -1.5% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +4.8% ✅ title_aspectTime: ✅ 2.437µs (SLO: <10.000µs 📉 -75.6%) vs baseline: +3.6% Memory: ✅ 40.423MB (SLO: <41.500MB -2.6%) vs baseline: +5.0% ✅ title_noaspectTime: ✅ 0.504µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.6% Memory: ✅ 40.344MB (SLO: <41.500MB -2.8%) vs baseline: +5.2% ✅ translate_aspectTime: ✅ 3.299µs (SLO: <10.000µs 📉 -67.0%) vs baseline: ~same Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +4.7% ✅ translate_noaspectTime: ✅ 1.042µs (SLO: <10.000µs 📉 -89.6%) vs baseline: +0.6% Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +4.0% ✅ upper_aspectTime: ✅ 2.303µs (SLO: <10.000µs 📉 -77.0%) vs baseline: +3.4% Memory: ✅ 40.305MB (SLO: <41.500MB -2.9%) vs baseline: +4.8% ✅ upper_noaspectTime: ✅ 0.369µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.2% Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +5.0% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.224µs (SLO: <10.000µs 📉 -47.8%) vs baseline: 📈 +25.8% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.2% ✅ ospathbasename_noaspectTime: ✅ 1.081µs (SLO: <10.000µs 📉 -89.2%) vs baseline: -0.9% Memory: ✅ 40.088MB (SLO: <41.000MB -2.2%) vs baseline: +4.4% ✅ ospathjoin_aspectTime: ✅ 6.146µs (SLO: <10.000µs 📉 -38.5%) vs baseline: -0.4% Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +4.9% ✅ ospathjoin_noaspectTime: ✅ 2.291µs (SLO: <10.000µs 📉 -77.1%) vs baseline: -0.3% Memory: ✅ 40.462MB (SLO: <41.000MB 🟡 -1.3%) vs baseline: +5.1% ✅ ospathnormcase_aspectTime: ✅ 3.459µs (SLO: <10.000µs 📉 -65.4%) vs baseline: +0.7% Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.7% ✅ ospathnormcase_noaspectTime: ✅ 0.572µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -0.9% Memory: ✅ 40.344MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +5.1% ✅ ospathsplit_aspectTime: ✅ 4.756µs (SLO: <10.000µs 📉 -52.4%) vs baseline: -0.2% Memory: ✅ 40.206MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.6% ✅ ospathsplit_noaspectTime: ✅ 1.581µs (SLO: <10.000µs 📉 -84.2%) vs baseline: -0.2% Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.7% ✅ ospathsplitdrive_aspectTime: ✅ 3.668µs (SLO: <10.000µs 📉 -63.3%) vs baseline: +0.5% Memory: ✅ 40.128MB (SLO: <41.000MB -2.1%) vs baseline: +4.8% ✅ ospathsplitdrive_noaspectTime: ✅ 0.717µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +1.8% Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.0% ✅ ospathsplitext_aspectTime: ✅ 4.526µs (SLO: <10.000µs 📉 -54.7%) vs baseline: -0.9% Memory: ✅ 40.324MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +4.7% ✅ ospathsplitext_noaspectTime: ✅ 1.383µs (SLO: <10.000µs 📉 -86.2%) vs baseline: ~same Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +4.7% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.398µs (SLO: <20.000µs 📉 -83.0%) vs baseline: 📈 +15.1% Memory: ✅ 35.075MB (SLO: <35.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ 1-count-metrics-100-timesTime: ✅ 202.388µs (SLO: <220.000µs -8.0%) vs baseline: -0.2% Memory: ✅ 34.996MB (SLO: <35.500MB 🟡 -1.4%) vs baseline: +4.5% ✅ 1-distribution-metric-1-timesTime: ✅ 3.343µs (SLO: <20.000µs 📉 -83.3%) vs baseline: +1.3% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +4.0% ✅ 1-distribution-metrics-100-timesTime: ✅ 217.251µs (SLO: <230.000µs -5.5%) vs baseline: -0.3% Memory: ✅ 35.114MB (SLO: <35.500MB 🟡 -1.1%) vs baseline: +4.9% ✅ 1-gauge-metric-1-timesTime: ✅ 2.137µs (SLO: <20.000µs 📉 -89.3%) vs baseline: -0.5% Memory: ✅ 35.114MB (SLO: <35.500MB 🟡 -1.1%) vs baseline: +4.6% ✅ 1-gauge-metrics-100-timesTime: ✅ 137.333µs (SLO: <150.000µs -8.4%) vs baseline: +0.9% Memory: ✅ 35.134MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +5.0% ✅ 1-rate-metric-1-timesTime: ✅ 3.072µs (SLO: <20.000µs 📉 -84.6%) vs baseline: -1.3% Memory: ✅ 34.800MB (SLO: <35.500MB 🟡 -2.0%) vs baseline: +3.8% ✅ 1-rate-metrics-100-timesTime: ✅ 214.018µs (SLO: <250.000µs 📉 -14.4%) vs baseline: ~same Memory: ✅ 35.036MB (SLO: <35.500MB 🟡 -1.3%) vs baseline: +4.7% ✅ 100-count-metrics-100-timesTime: ✅ 20.343ms (SLO: <22.000ms -7.5%) vs baseline: -0.7% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.8% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.288ms (SLO: <2.550ms 📉 -10.3%) vs baseline: -0.3% Memory: ✅ 34.701MB (SLO: <35.500MB -2.2%) vs baseline: +4.7% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.401ms (SLO: <1.550ms -9.6%) vs baseline: ~same Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.5% ✅ 100-rate-metrics-100-timesTime: ✅ 2.210ms (SLO: <2.550ms 📉 -13.3%) vs baseline: +0.3% Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.8% ✅ flush-1-metricTime: ✅ 4.619µs (SLO: <20.000µs 📉 -76.9%) vs baseline: +0.2% Memory: ✅ 35.075MB (SLO: <35.500MB 🟡 -1.2%) vs baseline: +4.7% ✅ flush-100-metricsTime: ✅ 173.850µs (SLO: <250.000µs 📉 -30.5%) vs baseline: +0.2% Memory: ✅ 35.173MB (SLO: <35.500MB 🟡 -0.9%) vs baseline: +5.0% ✅ flush-1000-metricsTime: ✅ 2.175ms (SLO: <2.500ms 📉 -13.0%) vs baseline: -0.2% Memory: ✅ 36.019MB (SLO: <36.500MB 🟡 -1.3%) vs baseline: +5.2% 🟡 Near SLO Breach (17 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Description
https://datadoghq.atlassian.net/browse/PROF-13197
WIP