-
Notifications
You must be signed in to change notification settings - Fork 469
chore(profiling): improve typing in _gevent.py
#15502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 253 ± 4 ms. The average import time from base is: 255 ± 4 ms. The import time difference between this PR and base is: -2.3 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate kowalski/wip-typing (307c5d6) with baseline main (874de50) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.399µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.7% Memory: ✅ 40.174MB (SLO: <41.500MB -3.2%) vs baseline: +4.8% ✅ add_inplace_aspectTime: ✅ 0.404µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.4% Memory: ✅ 40.166MB (SLO: <41.500MB -3.2%) vs baseline: +4.7% ✅ add_inplace_noaspectTime: ✅ 0.321µs (SLO: <10.000µs 📉 -96.8%) vs baseline: +0.9% Memory: ✅ 40.212MB (SLO: <41.500MB -3.1%) vs baseline: +4.9% ✅ add_noaspectTime: ✅ 0.279µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +1.0% Memory: ✅ 40.273MB (SLO: <41.500MB -3.0%) vs baseline: +4.8% ✅ bytearray_aspectTime: ✅ 1.351µs (SLO: <10.000µs 📉 -86.5%) vs baseline: -0.2% Memory: ✅ 40.314MB (SLO: <41.500MB -2.9%) vs baseline: +5.2% ✅ bytearray_extend_aspectTime: ✅ 1.496µs (SLO: <10.000µs 📉 -85.0%) vs baseline: -0.8% Memory: ✅ 40.334MB (SLO: <41.500MB -2.8%) vs baseline: +5.0% ✅ bytearray_extend_noaspectTime: ✅ 0.614µs (SLO: <10.000µs 📉 -93.9%) vs baseline: -0.5% Memory: ✅ 40.154MB (SLO: <41.500MB -3.2%) vs baseline: +5.0% ✅ bytearray_noaspectTime: ✅ 0.478µs (SLO: <10.000µs 📉 -95.2%) vs baseline: -0.8% Memory: ✅ 40.172MB (SLO: <41.500MB -3.2%) vs baseline: +4.9% ✅ bytes_aspectTime: ✅ 1.304µs (SLO: <10.000µs 📉 -87.0%) vs baseline: +1.5% Memory: ✅ 40.154MB (SLO: <41.500MB -3.2%) vs baseline: +4.3% ✅ bytes_noaspectTime: ✅ 0.490µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -1.1% Memory: ✅ 40.251MB (SLO: <41.500MB -3.0%) vs baseline: +5.4% ✅ bytesio_aspectTime: ✅ 1.338µs (SLO: <10.000µs 📉 -86.6%) vs baseline: +0.3% Memory: ✅ 40.353MB (SLO: <41.500MB -2.8%) vs baseline: +5.3% ✅ bytesio_noaspectTime: ✅ 0.497µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.9% Memory: ✅ 40.229MB (SLO: <41.500MB -3.1%) vs baseline: +4.7% ✅ capitalize_aspectTime: ✅ 0.734µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.9% Memory: ✅ 40.087MB (SLO: <41.500MB -3.4%) vs baseline: +4.3% ✅ capitalize_noaspectTime: ✅ 0.432µs (SLO: <10.000µs 📉 -95.7%) vs baseline: -0.9% Memory: ✅ 40.131MB (SLO: <41.500MB -3.3%) vs baseline: +4.1% ✅ casefold_aspectTime: ✅ 0.736µs (SLO: <10.000µs 📉 -92.6%) vs baseline: ~same Memory: ✅ 40.193MB (SLO: <41.500MB -3.1%) vs baseline: +4.9% ✅ casefold_noaspectTime: ✅ 0.368µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -1.2% Memory: ✅ 40.332MB (SLO: <41.500MB -2.8%) vs baseline: +5.2% ✅ decode_aspectTime: ✅ 0.728µs (SLO: <10.000µs 📉 -92.7%) vs baseline: +0.8% Memory: ✅ 40.132MB (SLO: <41.500MB -3.3%) vs baseline: +4.6% ✅ decode_noaspectTime: ✅ 0.422µs (SLO: <10.000µs 📉 -95.8%) vs baseline: ~same Memory: ✅ 40.212MB (SLO: <41.500MB -3.1%) vs baseline: +4.9% ✅ encode_aspectTime: ✅ 0.711µs (SLO: <10.000µs 📉 -92.9%) vs baseline: +0.3% Memory: ✅ 40.171MB (SLO: <41.500MB -3.2%) vs baseline: +5.0% ✅ encode_noaspectTime: ✅ 0.401µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -1.9% Memory: ✅ 40.054MB (SLO: <41.500MB -3.5%) vs baseline: +4.3% ✅ format_aspectTime: ✅ 3.411µs (SLO: <10.000µs 📉 -65.9%) vs baseline: -0.9% Memory: ✅ 40.127MB (SLO: <41.500MB -3.3%) vs baseline: +4.4% ✅ format_map_aspectTime: ✅ 3.531µs (SLO: <10.000µs 📉 -64.7%) vs baseline: -0.6% Memory: ✅ 40.348MB (SLO: <41.500MB -2.8%) vs baseline: +5.1% ✅ format_map_noaspectTime: ✅ 0.770µs (SLO: <10.000µs 📉 -92.3%) vs baseline: -0.5% Memory: ✅ 39.990MB (SLO: <41.500MB -3.6%) vs baseline: +4.2% ✅ format_noaspectTime: ✅ 0.600µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +0.6% Memory: ✅ 40.233MB (SLO: <41.500MB -3.1%) vs baseline: +4.9% ✅ index_aspectTime: ✅ 0.356µs (SLO: <10.000µs 📉 -96.4%) vs baseline: -0.7% Memory: ✅ 40.172MB (SLO: <41.500MB -3.2%) vs baseline: +4.5% ✅ index_noaspectTime: ✅ 0.273µs (SLO: <10.000µs 📉 -97.3%) vs baseline: -0.8% Memory: ✅ 40.073MB (SLO: <41.500MB -3.4%) vs baseline: +4.0% ✅ join_aspectTime: ✅ 1.333µs (SLO: <10.000µs 📉 -86.7%) vs baseline: -0.4% Memory: ✅ 40.014MB (SLO: <41.500MB -3.6%) vs baseline: +4.5% ✅ join_noaspectTime: ✅ 0.490µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.7% Memory: ✅ 40.153MB (SLO: <41.500MB -3.2%) vs baseline: +4.7% ✅ ljust_aspectTime: ✅ 2.624µs (SLO: <20.000µs 📉 -86.9%) vs baseline: +2.4% Memory: ✅ 40.153MB (SLO: <41.500MB -3.2%) vs baseline: +4.9% ✅ ljust_noaspectTime: ✅ 0.404µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +0.5% Memory: ✅ 40.152MB (SLO: <41.500MB -3.2%) vs baseline: +4.9% ✅ lower_aspectTime: ✅ 2.299µs (SLO: <10.000µs 📉 -77.0%) vs baseline: +2.2% Memory: ✅ 40.193MB (SLO: <41.500MB -3.1%) vs baseline: +4.9% ✅ lower_noaspectTime: ✅ 0.366µs (SLO: <10.000µs 📉 -96.3%) vs baseline: ~same Memory: ✅ 40.213MB (SLO: <41.500MB -3.1%) vs baseline: +4.8% ✅ lstrip_aspectTime: ✅ 2.236µs (SLO: <20.000µs 📉 -88.8%) vs baseline: ~same Memory: ✅ 40.109MB (SLO: <41.500MB -3.4%) vs baseline: +4.4% ✅ lstrip_noaspectTime: ✅ 0.381µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -1.3% Memory: ✅ 40.291MB (SLO: <41.500MB -2.9%) vs baseline: +5.2% ✅ modulo_aspectTime: ✅ 1.035µs (SLO: <10.000µs 📉 -89.7%) vs baseline: +4.8% Memory: ✅ 40.216MB (SLO: <41.500MB -3.1%) vs baseline: +4.5% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.543µs (SLO: <10.000µs 📉 -84.6%) vs baseline: -1.6% Memory: ✅ 40.156MB (SLO: <41.500MB -3.2%) vs baseline: +4.1% ✅ modulo_aspect_for_bytesTime: ✅ 0.979µs (SLO: <10.000µs 📉 -90.2%) vs baseline: -0.3% Memory: ✅ 40.156MB (SLO: <41.500MB -3.2%) vs baseline: +4.4% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.253µs (SLO: <10.000µs 📉 -87.5%) vs baseline: +2.6% Memory: ✅ 40.199MB (SLO: <41.500MB -3.1%) vs baseline: +4.6% ✅ modulo_noaspectTime: ✅ 0.626µs (SLO: <10.000µs 📉 -93.7%) vs baseline: -0.3% Memory: ✅ 40.192MB (SLO: <41.500MB -3.2%) vs baseline: +4.7% ✅ replace_aspectTime: ✅ 4.848µs (SLO: <10.000µs 📉 -51.5%) vs baseline: -1.3% Memory: ✅ 40.172MB (SLO: <41.500MB -3.2%) vs baseline: +4.6% ✅ replace_noaspectTime: ✅ 0.459µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -0.9% Memory: ✅ 40.293MB (SLO: <41.500MB -2.9%) vs baseline: +5.2% ✅ repr_aspectTime: ✅ 0.902µs (SLO: <10.000µs 📉 -91.0%) vs baseline: ~same Memory: ✅ 40.294MB (SLO: <41.500MB -2.9%) vs baseline: +5.4% ✅ repr_noaspectTime: ✅ 0.416µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -0.2% Memory: ✅ 40.095MB (SLO: <41.500MB -3.4%) vs baseline: +4.6% ✅ rstrip_aspectTime: ✅ 1.954µs (SLO: <20.000µs 📉 -90.2%) vs baseline: +1.5% Memory: ✅ 40.146MB (SLO: <41.500MB -3.3%) vs baseline: +4.5% ✅ rstrip_noaspectTime: ✅ 0.384µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +1.0% Memory: ✅ 40.191MB (SLO: <41.500MB -3.2%) vs baseline: +4.9% ✅ slice_aspectTime: ✅ 0.491µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.7% Memory: ✅ 40.214MB (SLO: <41.500MB -3.1%) vs baseline: +4.8% ✅ slice_noaspectTime: ✅ 0.445µs (SLO: <10.000µs 📉 -95.5%) vs baseline: -0.2% Memory: ✅ 40.212MB (SLO: <41.500MB -3.1%) vs baseline: +4.5% ✅ stringio_aspectTime: ✅ 1.534µs (SLO: <10.000µs 📉 -84.7%) vs baseline: -0.2% Memory: ✅ 40.211MB (SLO: <41.500MB -3.1%) vs baseline: +5.0% ✅ stringio_noaspectTime: ✅ 0.717µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +0.9% Memory: ✅ 40.331MB (SLO: <41.500MB -2.8%) vs baseline: +5.3% ✅ strip_aspectTime: ✅ 2.223µs (SLO: <20.000µs 📉 -88.9%) vs baseline: -0.4% Memory: ✅ 40.212MB (SLO: <41.500MB -3.1%) vs baseline: +5.0% ✅ strip_noaspectTime: ✅ 0.385µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.3% Memory: ✅ 40.353MB (SLO: <41.500MB -2.8%) vs baseline: +5.0% ✅ swapcase_aspectTime: ✅ 2.520µs (SLO: <10.000µs 📉 -74.8%) vs baseline: +3.5% Memory: ✅ 40.172MB (SLO: <41.500MB -3.2%) vs baseline: +4.7% ✅ swapcase_noaspectTime: ✅ 0.534µs (SLO: <10.000µs 📉 -94.7%) vs baseline: -0.7% Memory: ✅ 40.292MB (SLO: <41.500MB -2.9%) vs baseline: +5.1% ✅ title_aspectTime: ✅ 2.445µs (SLO: <10.000µs 📉 -75.5%) vs baseline: +3.2% Memory: ✅ 40.172MB (SLO: <41.500MB -3.2%) vs baseline: +4.7% ✅ title_noaspectTime: ✅ 0.506µs (SLO: <10.000µs 📉 -94.9%) vs baseline: +0.2% Memory: ✅ 40.112MB (SLO: <41.500MB -3.3%) vs baseline: +4.8% ✅ translate_aspectTime: ✅ 3.327µs (SLO: <10.000µs 📉 -66.7%) vs baseline: +0.8% Memory: ✅ 40.013MB (SLO: <41.500MB -3.6%) vs baseline: +4.5% ✅ translate_noaspectTime: ✅ 1.035µs (SLO: <10.000µs 📉 -89.6%) vs baseline: -0.2% Memory: ✅ 40.151MB (SLO: <41.500MB -3.3%) vs baseline: +4.4% ✅ upper_aspectTime: ✅ 2.631µs (SLO: <10.000µs 📉 -73.7%) vs baseline: 📈 +17.2% Memory: ✅ 40.194MB (SLO: <41.500MB -3.1%) vs baseline: +4.7% ✅ upper_noaspectTime: ✅ 0.368µs (SLO: <10.000µs 📉 -96.3%) vs baseline: ~same Memory: ✅ 40.211MB (SLO: <41.500MB -3.1%) vs baseline: +5.3% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.162µs (SLO: <10.000µs 📉 -48.4%) vs baseline: 📈 +23.8% Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +4.7% ✅ ospathbasename_noaspectTime: ✅ 1.077µs (SLO: <10.000µs 📉 -89.2%) vs baseline: +0.3% Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +5.1% ✅ ospathjoin_aspectTime: ✅ 6.175µs (SLO: <10.000µs 📉 -38.2%) vs baseline: -0.1% Memory: ✅ 40.265MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.9% ✅ ospathjoin_noaspectTime: ✅ 2.302µs (SLO: <10.000µs 📉 -77.0%) vs baseline: +0.5% Memory: ✅ 40.147MB (SLO: <41.000MB -2.1%) vs baseline: +4.8% ✅ ospathnormcase_aspectTime: ✅ 3.407µs (SLO: <10.000µs 📉 -65.9%) vs baseline: -0.9% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.5% ✅ ospathnormcase_noaspectTime: ✅ 0.562µs (SLO: <10.000µs 📉 -94.4%) vs baseline: -1.1% Memory: ✅ 40.324MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +4.9% ✅ ospathsplit_aspectTime: ✅ 4.736µs (SLO: <10.000µs 📉 -52.6%) vs baseline: -0.2% Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +4.6% ✅ ospathsplit_noaspectTime: ✅ 1.594µs (SLO: <10.000µs 📉 -84.1%) vs baseline: +0.4% Memory: ✅ 40.108MB (SLO: <41.000MB -2.2%) vs baseline: +4.1% ✅ ospathsplitdrive_aspectTime: ✅ 3.572µs (SLO: <10.000µs 📉 -64.3%) vs baseline: -2.4% Memory: ✅ 40.088MB (SLO: <41.000MB -2.2%) vs baseline: +4.4% ✅ ospathsplitdrive_noaspectTime: ✅ 0.701µs (SLO: <10.000µs 📉 -93.0%) vs baseline: +0.2% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.7% ✅ ospathsplitext_aspectTime: ✅ 4.487µs (SLO: <10.000µs 📉 -55.1%) vs baseline: -0.5% Memory: ✅ 40.246MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +4.8% ✅ ospathsplitext_noaspectTime: ✅ 1.372µs (SLO: <10.000µs 📉 -86.3%) vs baseline: -1.1% Memory: ✅ 40.167MB (SLO: <41.000MB -2.0%) vs baseline: +5.0% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.360µs (SLO: <20.000µs 📉 -83.2%) vs baseline: 📈 +15.5% Memory: ✅ 34.701MB (SLO: <35.500MB -2.2%) vs baseline: +4.4% ✅ 1-count-metrics-100-timesTime: ✅ 200.141µs (SLO: <220.000µs -9.0%) vs baseline: -1.4% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +5.0% ✅ 1-distribution-metric-1-timesTime: ✅ 3.256µs (SLO: <20.000µs 📉 -83.7%) vs baseline: -1.6% Memory: ✅ 34.682MB (SLO: <35.500MB -2.3%) vs baseline: +4.5% ✅ 1-distribution-metrics-100-timesTime: ✅ 216.684µs (SLO: <230.000µs -5.8%) vs baseline: -0.5% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.3% ✅ 1-gauge-metric-1-timesTime: ✅ 2.159µs (SLO: <20.000µs 📉 -89.2%) vs baseline: ~same Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +5.0% ✅ 1-gauge-metrics-100-timesTime: ✅ 135.938µs (SLO: <150.000µs -9.4%) vs baseline: -0.3% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +5.0% ✅ 1-rate-metric-1-timesTime: ✅ 3.052µs (SLO: <20.000µs 📉 -84.7%) vs baseline: -1.2% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +5.1% ✅ 1-rate-metrics-100-timesTime: ✅ 216.401µs (SLO: <250.000µs 📉 -13.4%) vs baseline: +1.1% Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 20.446ms (SLO: <22.000ms -7.1%) vs baseline: +0.9% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +5.2% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.273ms (SLO: <2.550ms 📉 -10.9%) vs baseline: +0.3% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.9% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.408ms (SLO: <1.550ms -9.2%) vs baseline: -0.5% Memory: ✅ 34.760MB (SLO: <35.500MB -2.1%) vs baseline: +4.7% ✅ 100-rate-metrics-100-timesTime: ✅ 2.216ms (SLO: <2.550ms 📉 -13.1%) vs baseline: -0.4% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ flush-1-metricTime: ✅ 4.589µs (SLO: <20.000µs 📉 -77.1%) vs baseline: -0.9% Memory: ✅ 35.114MB (SLO: <35.500MB 🟡 -1.1%) vs baseline: +4.9% ✅ flush-100-metricsTime: ✅ 173.221µs (SLO: <250.000µs 📉 -30.7%) vs baseline: -0.6% Memory: ✅ 35.134MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +4.7% ✅ flush-1000-metricsTime: ✅ 2.183ms (SLO: <2.500ms 📉 -12.7%) vs baseline: ~same Memory: ✅ 35.979MB (SLO: <36.500MB 🟡 -1.4%) vs baseline: +4.9% 🟡 Near SLO Breach (15 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
738a001 to
9e1a49f
Compare
_gevent.py
9e1a49f to
2b0c806
Compare
2b0c806 to
307c5d6
Compare
Description
https://datadoghq.atlassian.net/browse/PROF-13197