-
Notifications
You must be signed in to change notification settings - Fork 469
feat(llmobs): add tag source:otel to evals if DD_TRACE_OTEL_ENABLED=true #15538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 245 ± 3 ms. The average import time from base is: 251 ± 4 ms. The import time difference between this PR and base is: -6.1 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate zachg/llmobs_otel_evals_update (b5483cf) with baseline main (ca3c521) 📈 Performance Regressions (3 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.405µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.3% Memory: ✅ 40.185MB (SLO: <41.500MB -3.2%) vs baseline: +4.6% ✅ add_inplace_aspectTime: ✅ 0.403µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.2% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +4.9% ✅ add_inplace_noaspectTime: ✅ 0.317µs (SLO: <10.000µs 📉 -96.8%) vs baseline: ~same Memory: ✅ 40.128MB (SLO: <41.500MB -3.3%) vs baseline: +4.9% ✅ add_noaspectTime: ✅ 0.275µs (SLO: <10.000µs 📉 -97.3%) vs baseline: -0.2% Memory: ✅ 40.423MB (SLO: <41.500MB -2.6%) vs baseline: +5.2% ✅ bytearray_aspectTime: ✅ 1.351µs (SLO: <10.000µs 📉 -86.5%) vs baseline: -0.5% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +4.6% ✅ bytearray_extend_aspectTime: ✅ 1.501µs (SLO: <10.000µs 📉 -85.0%) vs baseline: -0.3% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +5.1% ✅ bytearray_extend_noaspectTime: ✅ 0.609µs (SLO: <10.000µs 📉 -93.9%) vs baseline: -0.6% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +4.5% ✅ bytearray_noaspectTime: ✅ 0.490µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.6% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +4.8% ✅ bytes_aspectTime: ✅ 1.299µs (SLO: <10.000µs 📉 -87.0%) vs baseline: -0.5% Memory: ✅ 40.088MB (SLO: <41.500MB -3.4%) vs baseline: +4.3% ✅ bytes_noaspectTime: ✅ 0.499µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +1.3% Memory: ✅ 40.324MB (SLO: <41.500MB -2.8%) vs baseline: +5.4% ✅ bytesio_aspectTime: ✅ 1.354µs (SLO: <10.000µs 📉 -86.5%) vs baseline: +1.9% Memory: ✅ 40.147MB (SLO: <41.500MB -3.3%) vs baseline: +4.9% ✅ bytesio_noaspectTime: ✅ 0.494µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.2% Memory: ✅ 40.128MB (SLO: <41.500MB -3.3%) vs baseline: +4.3% ✅ capitalize_aspectTime: ✅ 0.738µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.4% Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +4.0% ✅ capitalize_noaspectTime: ✅ 0.432µs (SLO: <10.000µs 📉 -95.7%) vs baseline: -0.3% Memory: ✅ 40.285MB (SLO: <41.500MB -2.9%) vs baseline: +4.8% ✅ casefold_aspectTime: ✅ 0.743µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +1.1% Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +4.6% ✅ casefold_noaspectTime: ✅ 0.366µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.3% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +5.0% ✅ decode_aspectTime: ✅ 0.719µs (SLO: <10.000µs 📉 -92.8%) vs baseline: -1.2% Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +4.8% ✅ decode_noaspectTime: ✅ 0.417µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -0.6% Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +5.3% ✅ encode_aspectTime: ✅ 0.710µs (SLO: <10.000µs 📉 -92.9%) vs baseline: -0.2% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +4.9% ✅ encode_noaspectTime: ✅ 0.407µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +2.6% Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +4.8% ✅ format_aspectTime: ✅ 3.430µs (SLO: <10.000µs 📉 -65.7%) vs baseline: -2.2% Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +4.8% ✅ format_map_aspectTime: ✅ 3.572µs (SLO: <10.000µs 📉 -64.3%) vs baseline: -0.9% Memory: ✅ 40.128MB (SLO: <41.500MB -3.3%) vs baseline: +4.5% ✅ format_map_noaspectTime: ✅ 0.775µs (SLO: <10.000µs 📉 -92.3%) vs baseline: +0.2% Memory: ✅ 40.069MB (SLO: <41.500MB -3.4%) vs baseline: +4.5% ✅ format_noaspectTime: ✅ 0.594µs (SLO: <10.000µs 📉 -94.1%) vs baseline: -0.3% Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +4.4% ✅ index_aspectTime: ✅ 0.359µs (SLO: <10.000µs 📉 -96.4%) vs baseline: +1.3% Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +4.3% ✅ index_noaspectTime: ✅ 0.280µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +0.3% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +4.5% ✅ join_aspectTime: ✅ 1.345µs (SLO: <10.000µs 📉 -86.6%) vs baseline: +2.2% Memory: ✅ 40.285MB (SLO: <41.500MB -2.9%) vs baseline: +5.1% ✅ join_noaspectTime: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.4% Memory: ✅ 40.147MB (SLO: <41.500MB -3.3%) vs baseline: +4.3% ✅ ljust_aspectTime: ✅ 2.932µs (SLO: <20.000µs 📉 -85.3%) vs baseline: 📈 +14.3% Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +4.7% ✅ ljust_noaspectTime: ✅ 0.405µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.9% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +4.4% ✅ lower_aspectTime: ✅ 2.289µs (SLO: <10.000µs 📉 -77.1%) vs baseline: +2.4% Memory: ✅ 40.206MB (SLO: <41.500MB -3.1%) vs baseline: +5.0% ✅ lower_noaspectTime: ✅ 0.368µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.7% Memory: ✅ 40.108MB (SLO: <41.500MB -3.4%) vs baseline: +4.7% ✅ lstrip_aspectTime: ✅ 2.256µs (SLO: <20.000µs 📉 -88.7%) vs baseline: +0.4% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +4.9% ✅ lstrip_noaspectTime: ✅ 0.381µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.1% Memory: ✅ 40.147MB (SLO: <41.500MB -3.3%) vs baseline: +5.0% ✅ modulo_aspectTime: ✅ 1.046µs (SLO: <10.000µs 📉 -89.5%) vs baseline: +4.9% Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +4.8% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.539µs (SLO: <10.000µs 📉 -84.6%) vs baseline: -0.8% Memory: ✅ 40.226MB (SLO: <41.500MB -3.1%) vs baseline: +4.9% ✅ modulo_aspect_for_bytesTime: ✅ 0.978µs (SLO: <10.000µs 📉 -90.2%) vs baseline: +0.5% Memory: ✅ 40.088MB (SLO: <41.500MB -3.4%) vs baseline: +4.5% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.240µs (SLO: <10.000µs 📉 -87.6%) vs baseline: +1.3% Memory: ✅ 40.275MB (SLO: <41.500MB -3.0%) vs baseline: +4.7% ✅ modulo_noaspectTime: ✅ 0.622µs (SLO: <10.000µs 📉 -93.8%) vs baseline: -1.2% Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +4.3% ✅ replace_aspectTime: ✅ 4.888µs (SLO: <10.000µs 📉 -51.1%) vs baseline: -1.1% Memory: ✅ 40.128MB (SLO: <41.500MB -3.3%) vs baseline: +4.6% ✅ replace_noaspectTime: ✅ 0.461µs (SLO: <10.000µs 📉 -95.4%) vs baseline: ~same Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +4.7% ✅ repr_aspectTime: ✅ 0.905µs (SLO: <10.000µs 📉 -91.0%) vs baseline: -1.1% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +4.7% ✅ repr_noaspectTime: ✅ 0.413µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -0.9% Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +4.3% ✅ rstrip_aspectTime: ✅ 1.942µs (SLO: <20.000µs 📉 -90.3%) vs baseline: +0.9% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +4.8% ✅ rstrip_noaspectTime: ✅ 0.378µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -1.2% Memory: ✅ 40.246MB (SLO: <41.500MB -3.0%) vs baseline: +4.8% ✅ slice_aspectTime: ✅ 0.492µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.2% Memory: ✅ 40.147MB (SLO: <41.500MB -3.3%) vs baseline: +4.5% ✅ slice_noaspectTime: ✅ 0.447µs (SLO: <10.000µs 📉 -95.5%) vs baseline: +1.5% Memory: ✅ 40.344MB (SLO: <41.500MB -2.8%) vs baseline: +5.1% ✅ stringio_aspectTime: ✅ 1.553µs (SLO: <10.000µs 📉 -84.5%) vs baseline: +0.8% Memory: ✅ 40.285MB (SLO: <41.500MB -2.9%) vs baseline: +5.1% ✅ stringio_noaspectTime: ✅ 0.729µs (SLO: <10.000µs 📉 -92.7%) vs baseline: +2.5% Memory: ✅ 40.501MB (SLO: <41.500MB -2.4%) vs baseline: +5.4% ✅ strip_aspectTime: ✅ 2.222µs (SLO: <20.000µs 📉 -88.9%) vs baseline: +0.2% Memory: ✅ 40.225MB (SLO: <41.500MB -3.1%) vs baseline: +4.8% ✅ strip_noaspectTime: ✅ 0.384µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.3% Memory: ✅ 40.088MB (SLO: <41.500MB -3.4%) vs baseline: +4.3% ✅ swapcase_aspectTime: ✅ 2.808µs (SLO: <10.000µs 📉 -71.9%) vs baseline: 📈 +14.9% Memory: ✅ 40.088MB (SLO: <41.500MB -3.4%) vs baseline: +4.5% ✅ swapcase_noaspectTime: ✅ 0.535µs (SLO: <10.000µs 📉 -94.7%) vs baseline: -0.7% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +4.7% ✅ title_aspectTime: ✅ 2.421µs (SLO: <10.000µs 📉 -75.8%) vs baseline: +2.4% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +4.7% ✅ title_noaspectTime: ✅ 0.501µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -1.1% Memory: ✅ 40.167MB (SLO: <41.500MB -3.2%) vs baseline: +4.7% ✅ translate_aspectTime: ✅ 3.288µs (SLO: <10.000µs 📉 -67.1%) vs baseline: -1.2% Memory: ✅ 40.324MB (SLO: <41.500MB -2.8%) vs baseline: +5.4% ✅ translate_noaspectTime: ✅ 1.040µs (SLO: <10.000µs 📉 -89.6%) vs baseline: ~same Memory: ✅ 40.187MB (SLO: <41.500MB -3.2%) vs baseline: +4.5% ✅ upper_aspectTime: ✅ 2.332µs (SLO: <10.000µs 📉 -76.7%) vs baseline: +4.4% Memory: ✅ 40.323MB (SLO: <41.500MB -2.8%) vs baseline: +5.0% ✅ upper_noaspectTime: ✅ 0.367µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.5% Memory: ✅ 40.265MB (SLO: <41.500MB -3.0%) vs baseline: +5.0% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.170µs (SLO: <10.000µs 📉 -48.3%) vs baseline: 📈 +24.9% Memory: ✅ 40.147MB (SLO: <41.000MB -2.1%) vs baseline: +4.6% ✅ ospathbasename_noaspectTime: ✅ 1.088µs (SLO: <10.000µs 📉 -89.1%) vs baseline: +0.4% Memory: ✅ 40.246MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +5.0% ✅ ospathjoin_aspectTime: ✅ 6.145µs (SLO: <10.000µs 📉 -38.6%) vs baseline: ~same Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.7% ✅ ospathjoin_noaspectTime: ✅ 2.288µs (SLO: <10.000µs 📉 -77.1%) vs baseline: +0.4% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.0% ✅ ospathnormcase_aspectTime: ✅ 3.393µs (SLO: <10.000µs 📉 -66.1%) vs baseline: -0.6% Memory: ✅ 40.128MB (SLO: <41.000MB -2.1%) vs baseline: +4.3% ✅ ospathnormcase_noaspectTime: ✅ 0.572µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -0.8% Memory: ✅ 40.206MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.7% ✅ ospathsplit_aspectTime: ✅ 4.728µs (SLO: <10.000µs 📉 -52.7%) vs baseline: -0.3% Memory: ✅ 40.128MB (SLO: <41.000MB -2.1%) vs baseline: +4.8% ✅ ospathsplit_noaspectTime: ✅ 1.585µs (SLO: <10.000µs 📉 -84.2%) vs baseline: -0.4% Memory: ✅ 40.069MB (SLO: <41.000MB -2.3%) vs baseline: +4.3% ✅ ospathsplitdrive_aspectTime: ✅ 3.599µs (SLO: <10.000µs 📉 -64.0%) vs baseline: -2.2% Memory: ✅ 40.108MB (SLO: <41.000MB -2.2%) vs baseline: +5.0% ✅ ospathsplitdrive_noaspectTime: ✅ 0.699µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -0.2% Memory: ✅ 40.246MB (SLO: <41.000MB 🟡 -1.8%) vs baseline: +5.1% ✅ ospathsplitext_aspectTime: ✅ 4.534µs (SLO: <10.000µs 📉 -54.7%) vs baseline: +0.7% Memory: ✅ 40.147MB (SLO: <41.000MB -2.1%) vs baseline: +4.3% ✅ ospathsplitext_noaspectTime: ✅ 1.383µs (SLO: <10.000µs 📉 -86.2%) vs baseline: ~same Memory: ✅ 40.128MB (SLO: <41.000MB -2.1%) vs baseline: +4.1% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.394µs (SLO: <20.000µs 📉 -83.0%) vs baseline: 📈 +16.5% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +5.5% ✅ 1-count-metrics-100-timesTime: ✅ 201.703µs (SLO: <220.000µs -8.3%) vs baseline: +0.1% Memory: ✅ 34.878MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.3% ✅ 1-distribution-metric-1-timesTime: ✅ 3.299µs (SLO: <20.000µs 📉 -83.5%) vs baseline: +0.5% Memory: ✅ 34.721MB (SLO: <35.500MB -2.2%) vs baseline: +4.1% ✅ 1-distribution-metrics-100-timesTime: ✅ 217.755µs (SLO: <230.000µs -5.3%) vs baseline: +0.3% Memory: ✅ 34.839MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.3% ✅ 1-gauge-metric-1-timesTime: ✅ 2.175µs (SLO: <20.000µs 📉 -89.1%) vs baseline: +0.2% Memory: ✅ 34.957MB (SLO: <35.500MB 🟡 -1.5%) vs baseline: +5.3% ✅ 1-gauge-metrics-100-timesTime: ✅ 137.109µs (SLO: <150.000µs -8.6%) vs baseline: +1.1% Memory: ✅ 34.859MB (SLO: <35.500MB 🟡 -1.8%) vs baseline: +5.0% ✅ 1-rate-metric-1-timesTime: ✅ 3.073µs (SLO: <20.000µs 📉 -84.6%) vs baseline: -0.3% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ 1-rate-metrics-100-timesTime: ✅ 213.844µs (SLO: <250.000µs 📉 -14.5%) vs baseline: -0.3% Memory: ✅ 34.898MB (SLO: <35.500MB 🟡 -1.7%) vs baseline: +5.5% ✅ 100-count-metrics-100-timesTime: ✅ 20.184ms (SLO: <22.000ms -8.3%) vs baseline: -1.4% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.302ms (SLO: <2.550ms -9.7%) vs baseline: +0.1% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.6% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.405ms (SLO: <1.550ms -9.3%) vs baseline: +0.5% Memory: ✅ 34.819MB (SLO: <35.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.193ms (SLO: <2.550ms 📉 -14.0%) vs baseline: -1.0% Memory: ✅ 34.780MB (SLO: <35.500MB -2.0%) vs baseline: +4.7% ✅ flush-1-metricTime: ✅ 4.631µs (SLO: <20.000µs 📉 -76.8%) vs baseline: ~same Memory: ✅ 35.154MB (SLO: <35.500MB 🟡 -1.0%) vs baseline: +5.1% ✅ flush-100-metricsTime: ✅ 175.526µs (SLO: <250.000µs 📉 -29.8%) vs baseline: +0.2% Memory: ✅ 35.173MB (SLO: <35.500MB 🟡 -0.9%) vs baseline: +5.1% ✅ flush-1000-metricsTime: ✅ 2.179ms (SLO: <2.500ms 📉 -12.9%) vs baseline: -0.1% Memory: ✅ 35.940MB (SLO: <36.500MB 🟡 -1.5%) vs baseline: +4.9% 🟡 Near SLO Breach (16 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Description
Auto-add
source:oteltag to LLMObs evaluations when OTel tracing is enabledWhen
DD_TRACE_OTEL_ENABLED=true, automatically addssource:oteltag to all submitted evaluations. This allows the backend to wait ~3 minutes for OTel span conversion before discarding unmatched evaluations.Changes
source:oteltag insubmit_evaluation()when OTel tracing is enabledTesting
test_submit_evaluation_adds_source_otel_when_otel_enabledtest_submit_evaluation_no_source_otel_when_otel_disabledRisks
Additional Notes