Skip to content

Commit d1bfb76

Browse files
committed
Address PR feedback
1 parent 0ed43ba commit d1bfb76

File tree

6 files changed

+7
-35
lines changed

6 files changed

+7
-35
lines changed

lib/datadog/core/remote/client/capabilities.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ def register(settings)
3939
register_receivers(Datadog::DI::Remote.receivers(@telemetry))
4040
end
4141

42-
if settings.respond_to?(:open_feature) && settings.open_feature.enabled
42+
if settings.open_feature.enabled
4343
register_capabilities(Datadog::OpenFeature::Remote.capabilities)
4444
register_products(Datadog::OpenFeature::Remote.products)
4545
register_receivers(Datadog::OpenFeature::Remote.receivers(@telemetry))

lib/datadog/open_feature.rb

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
# frozen_string_literal: true
22

3-
require_relative 'open_feature/extensions'
3+
require_relative 'core/configuration'
4+
require_relative 'open_feature/configuration'
45

56
module Datadog
67
# A namespace for the OpenFeature component.
78
module OpenFeature
8-
Extensions.activate!
9+
Core::Configuration::Settings.extend(Configuration::Settings)
910

1011
def self.enabled?
1112
Datadog.configuration.open_feature.enabled

lib/datadog/open_feature/component.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@ class Component
1111
attr_reader :telemetry, :engine
1212

1313
def self.build(settings, agent_settings, logger:, telemetry:)
14-
return unless settings.respond_to?(:open_feature) && settings.open_feature.enabled
14+
return unless settings.open_feature.enabled
1515

16-
unless settings.respond_to?(:remote) && settings.remote.enabled
17-
logger.warn('OpenFeature: Could not be enabled without Remote Configuration Management available')
16+
unless settings.remote.enabled
17+
logger.warn('OpenFeature: Could not be enabled without Remote Configuration Management available. To enable Remote Configuration, see https://docs.datadoghq.com/agent/remote_config')
1818

1919
return
2020
end

lib/datadog/open_feature/extensions.rb

Lines changed: 0 additions & 14 deletions
This file was deleted.

sig/datadog/open_feature/extensions.rbs

Lines changed: 0 additions & 7 deletions
This file was deleted.

spec/datadog/open_feature/component_spec.rb

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -65,14 +65,6 @@
6565

6666
it { expect(component).to be_nil }
6767
end
68-
69-
context 'when settings does not include open_feature' do
70-
before { allow(settings).to receive(:respond_to?).and_return(false) }
71-
72-
let(:settings) { instance_double(Datadog::Core::Configuration::Settings) }
73-
74-
it { expect(component).to be_nil }
75-
end
7668
end
7769

7870
describe '#shutdown!' do

0 commit comments

Comments
 (0)