Skip to content

Conversation

@Strech
Copy link
Member

@Strech Strech commented Oct 24, 2025

What does this PR do?

Adds a new component Datadog::OpenFeature that will give customers an opportunity to use Datadog::OpenFeature::Provider in their open feature SDK.

Motivation:

A Feature Flag Evaluation product we want to pilot.

Change log entry

Yes. TBD

Additional Notes:

This is a draft to work on, don't merge now.

How to test the change?

There will be unit tests added and also new system tests

@github-actions github-actions bot added the core Involves Datadog core libraries label Oct 24, 2025
@github-actions
Copy link

github-actions bot commented Oct 24, 2025

Typing analysis

Note: Ignored files are excluded from the next sections.

Untyped methods

This PR introduces 1 untyped method and 2 partially typed methods. It increases the percentage of typed methods from 51.66% to 52.43% (+0.77%).

Untyped methods (+1-0)Introduced:
sig/datadog/open_feature/provider.rbs:8
└── def initialize: () -> void
Partially typed methods (+2-0)Introduced:
sig/datadog/open_feature/binding/evaluator.rbs:41
└── def generate: (::Symbol expected_type) -> untyped
sig/datadog/open_feature/configuration/settings.rbs:12
└── def self.add_settings!: (untyped base) -> void

Untyped other declarations

This PR introduces 3 untyped other declarations. It increases the percentage of typed other declarations from 65.76% to 66.3% (+0.54%).

Untyped other declarations (+3-0)Introduced:
sig/datadog/open_feature/binding/evaluator.rbs:5
└── attr_reader value: untyped
sig/datadog/open_feature/binding/evaluator.rbs:9
└── attr_reader variant: untyped
sig/datadog/open_feature/binding/evaluator.rbs:15
└── attr_reader flag_metadata: untyped

If you believe a method or an attribute is rightfully untyped or partially typed, you can add # untyped:accept to the end of the line to remove it from the stats.

@pr-commenter
Copy link

pr-commenter bot commented Oct 24, 2025

Benchmarks

Benchmark execution time: 2025-11-07 14:47:52

Comparing candidate commit 9cd236e in PR branch add-openfeature-component with baseline commit 333959d in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 43 metrics, 2 unstable metrics.

scenario:profiling - sample timeline=false

  • 🟥 throughput [-0.420op/s; -0.372op/s] or [-5.960%; -5.269%]

@datadog-official

This comment has been minimized.

* Correct specs
* Rename existing binding stab
* Add tests for Evaluator
@Strech Strech changed the title [FFE] Add OpenFeature component [FFL-1318] Add OpenFeature component Oct 29, 2025
@github-actions github-actions bot added integrations Involves tracing integrations profiling Involves Datadog profiling appsec Application Security monitoring product tracing labels Nov 4, 2025
@Strech Strech force-pushed the add-openfeature-component branch from 628685b to 3339108 Compare November 4, 2025 20:14
@Strech Strech closed this Nov 11, 2025
@Strech Strech deleted the add-openfeature-component branch November 11, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

appsec Application Security monitoring product core Involves Datadog core libraries integrations Involves tracing integrations profiling Involves Datadog profiling tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants