Skip to content

Commit e23ac10

Browse files
cbeauchesnetylfin
andauthored
Cbeauchesne/debugger follow up (#5576)
Co-authored-by: Tyler Finethy <[email protected]>
1 parent 952b3f6 commit e23ac10

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

tests/debugger/test_debugger_probe_snapshot.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import tests.debugger.utils as debugger
77

88

9-
from utils import scenarios, features, missing_feature, context, irrelevant
9+
from utils import scenarios, features, missing_feature, context, irrelevant, bug
1010
from utils.interfaces._library.miscs import validate_process_tags
1111

1212

@@ -213,6 +213,7 @@ class Test_Debugger_Line_Probe_Snaphots(BaseDebuggerProbeSnaphotTest):
213213
def setup_log_line_snapshot(self):
214214
self._setup("probe_snapshot_log_line", "/debugger/log", "log", lines=None)
215215

216+
@bug(context.library == "nodejs", reason="DEBUG-4611")
216217
def test_log_line_snapshot(self):
217218
self._assert()
218219
self._validate_snapshots()
@@ -224,7 +225,6 @@ def setup_log_line_snapshot_debug_track(self):
224225
@missing_feature(context.library == "dotnet", reason="DEBUG-4341")
225226
@missing_feature(context.library == "ruby", reason="DEBUG-4343")
226227
@missing_feature(context.library == "nodejs", reason="DEBUG-4345")
227-
@missing_feature(context.library == "java", reason="APMRP-360")
228228
def test_log_line_snapshot_debug_track(self):
229229
"""Test that the library sends snapshots to the debug track endpoint (fallback or not)"""
230230
self._assert()
@@ -237,7 +237,7 @@ def setup_log_line_snapshot_new_destination(self):
237237
@missing_feature(context.library == "dotnet", reason="DEBUG-4341")
238238
@missing_feature(context.library == "ruby", reason="DEBUG-4343")
239239
@missing_feature(context.library == "nodejs", reason="DEBUG-4345")
240-
@missing_feature(context.library == "java", reason="APMRP-360")
240+
@missing_feature(context.agent_version < "7.72.0", reason="Endpoint was introduced in 7.72.0", force_skip=True)
241241
def test_log_line_snapshot_new_destination(self):
242242
"""Test that the library sends snapshots to the debugger/v2/input endpoint"""
243243
self._assert()
@@ -300,6 +300,7 @@ class Test_Debugger_Line_Probe_Snaphots_With_SCM(BaseDebuggerProbeSnaphotTest):
300300
def setup_log_line_snapshot(self):
301301
self._setup("probe_snapshot_log_line", "/debugger/log", "log", lines=None)
302302

303+
@bug(context.library == "nodejs", reason="DEBUG-4611")
303304
def test_log_line_snapshot(self):
304305
self._assert()
305306
self._validate_snapshots()

tests/debugger/utils/probes/probe_snapshot_log_line.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
"type": "",
55
"id": "",
66
"version": 0,
7+
"captureSnapshot": true,
78
"where": {
89
"typeName": null,
910
"sourceFile": "ACTUAL_SOURCE_FILE",

0 commit comments

Comments
 (0)