Skip to content

Commit 1be6813

Browse files
Use sandbox screenshot uploader
Closes #17
1 parent f7007c9 commit 1be6813

4 files changed

Lines changed: 54 additions & 1 deletion

File tree

.claude/agents/designer.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,19 @@ Do not use this role for backend-only, queue, SES, SQS, Lambda, or data-model is
3333
4. Report hierarchy, spacing, typography, accessibility, and mobile issues.
3434
5. Provide concrete recommendations and file references.
3535

36+
## Screenshot Uploads
37+
38+
Save screenshots under `.tmp/` in the Datamailer checkout and upload them with the shared sandbox screenshot CLI:
39+
40+
```bash
41+
cd /home/alexey/git/sandbox-screenshots
42+
upload-screenshot /home/alexey/git/datamailer/.tmp/screenshot.png
43+
```
44+
45+
Read `/home/alexey/git/sandbox-screenshots/README.md` before uploading. If the CLI is missing or stale, run `./install.sh` from that repo and `source ~/.bashrc`.
46+
47+
Include returned `url` values in the audit. Do not use an orphan `screenshots` branch. If a local or remote `screenshots` branch exists, delete it, reupload screenshots with `upload-screenshot`, and update affected issue comments.
48+
3649
## Output
3750

3851
```markdown

.claude/agents/tester.md

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,14 @@ make test-aws-local
6565

6666
If LocalStack is unavailable and the issue only requires skip-safe local setup, verify the marked tests skip cleanly and report that. If the issue requires a real local queue run, start LocalStack or fail with concrete instructions.
6767

68-
For UI-visible changes, start the server, inspect the page, and capture/read screenshots when practical. For backend-only changes, state screenshots are not applicable.
68+
For UI-visible changes, start the server, inspect the page, and capture/read screenshots when practical. Save screenshots under `.tmp/` and upload shareable images with the sandbox screenshot CLI:
69+
70+
```bash
71+
cd /home/alexey/git/sandbox-screenshots
72+
upload-screenshot /home/alexey/git/datamailer/.tmp/screenshot.png
73+
```
74+
75+
Read `/home/alexey/git/sandbox-screenshots/README.md` before uploading. If the CLI is missing or stale, run `./install.sh` from that repo and `source ~/.bashrc`. Include the returned `url` values in the QA report. Do not use an orphan `screenshots` branch. If a local or remote `screenshots` branch exists, delete it, reupload screenshots with `upload-screenshot`, and update affected issue comments. For backend-only changes, state screenshots are not applicable.
6976

7077
### 4. Verify Acceptance Criteria
7178

docs/PROCESS.md

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,30 @@ Guidelines:
164164
- UI tests should start with Django view/template tests. Add Playwright only for critical user/operator workflows once the UI is substantial.
165165
- Capture screenshots only for UI issues with visible page changes. For backend-only issues, tester should explicitly state screenshots are not applicable.
166166

167+
## Screenshot Upload Workflow
168+
169+
Use the shared sandbox screenshot uploader for throw-away screenshot links. Do not create or update an orphan `screenshots` branch.
170+
171+
For UI-visible issues:
172+
173+
1. Save screenshots under `.tmp/` in this repo.
174+
2. Read `/home/alexey/git/sandbox-screenshots/README.md` before uploading.
175+
3. Install or refresh the CLI if needed:
176+
```bash
177+
cd /home/alexey/git/sandbox-screenshots
178+
./install.sh
179+
source ~/.bashrc
180+
```
181+
4. Upload each screenshot:
182+
```bash
183+
upload-screenshot /home/alexey/git/datamailer/.tmp/screenshot.png
184+
```
185+
5. Copy the returned `url` value into the GitHub issue comment, QA report, designer audit, or PM acceptance notes.
186+
187+
Do not paste `SCREENSHOT_UPLOAD_TOKEN` into chat, logs, commits, issue comments, or docs. Screenshot objects are temporary and expire automatically.
188+
189+
If a local or remote `screenshots` branch exists, delete that branch, reupload the relevant screenshot files with `upload-screenshot`, and update any issue comments that pointed at the old branch URLs.
190+
167191
## Datamailer Engineering Rules
168192

169193
- Do not send email from HTTP request handlers. Enqueue durable work.

docs/testing-guidelines.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,4 +74,13 @@ Use `Stubber` to assert:
7474

7575
Start with Django view/template tests. Add Playwright only when the UI workflow is critical and cannot be verified well with Django tests.
7676

77+
For UI-visible changes, save screenshots under `.tmp/` and upload them with the sandbox screenshot CLI:
78+
79+
```bash
80+
cd /home/alexey/git/sandbox-screenshots
81+
upload-screenshot /home/alexey/git/datamailer/.tmp/screenshot.png
82+
```
83+
84+
Read `/home/alexey/git/sandbox-screenshots/README.md` before uploading. Do not use an orphan `screenshots` branch. If a local or remote `screenshots` branch exists, delete it, reupload screenshots with `upload-screenshot`, and update affected issue comments.
85+
7786
For backend-only issues, screenshots are not applicable; tester should state that explicitly.

0 commit comments

Comments
 (0)