Skip to content

Commit 54d0315

Browse files
committed
Added two TODOs.
1 parent 1b01c5f commit 54d0315

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

lib/ecdsa.rb

+2
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
require_relative 'ecdsa/format'
77
require_relative 'ecdsa/version'
88

9+
# TODO: fix the broken URLs we have for SEC1 and SEC2 all over the code base
10+
911
# The top-level module for the ECDSA gem.
1012
module ECDSA
1113
# This method is NOT part of the public API of the ECDSA gem.

lib/ecdsa/sign.rb

+3
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@ module ECDSA
2020
# signature will be 0, in which case the method returns nil. If that happens,
2121
# you should generate a new temporary key and try again.
2222
def self.sign(group, private_key, digest, temporary_key)
23+
# TODO: add an option for specifying that the s value should be low,
24+
# which is needed by systems like Bitcoin: https://github.com/bitcoin/bips/blob/master/bip-0062.mediawiki#low-s-values-in-signatures
25+
2326
# Second part of step 1: Select ephemeral elliptic curve key pair
2427
# temporary_key was already selected for us by the caller
2528
r_point = group.new_point temporary_key

0 commit comments

Comments
 (0)