File tree 2 files changed +5
-0
lines changed
2 files changed +5
-0
lines changed Original file line number Diff line number Diff line change 6
6
require_relative 'ecdsa/format'
7
7
require_relative 'ecdsa/version'
8
8
9
+ # TODO: fix the broken URLs we have for SEC1 and SEC2 all over the code base
10
+
9
11
# The top-level module for the ECDSA gem.
10
12
module ECDSA
11
13
# This method is NOT part of the public API of the ECDSA gem.
Original file line number Diff line number Diff line change @@ -20,6 +20,9 @@ module ECDSA
20
20
# signature will be 0, in which case the method returns nil. If that happens,
21
21
# you should generate a new temporary key and try again.
22
22
def self . sign ( group , private_key , digest , temporary_key )
23
+ # TODO: add an option for specifying that the s value should be low,
24
+ # which is needed by systems like Bitcoin: https://github.com/bitcoin/bips/blob/master/bip-0062.mediawiki#low-s-values-in-signatures
25
+
23
26
# Second part of step 1: Select ephemeral elliptic curve key pair
24
27
# temporary_key was already selected for us by the caller
25
28
r_point = group . new_point temporary_key
You can’t perform that action at this time.
0 commit comments