Skip to content

Bug: normalize_counts=False zeroes out all sampling outputs #2

@haotianzh

Description

@haotianzh

When normalize_counts: false in the data config, the sampling code silently zeroes out all generated samples and ground truth arrays.

Root cause in sampling_generation.py:

if normalize_counts is not None:
    all_samples *= normalize_counts
    all_truths *= normalize_counts

Suggested fix:

if normalize_counts is not None and normalize_counts is not False:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions