fixes

Author: xynova

DOCKER_LOGGING_FIX.md

@@ -0,0 +1,102 @@
+# Docker Logging Configuration Fix
+
+## Issue Description
+
+The Docker containers created by the SWE Factory tool were using a logging configuration that disabled container logs:
+
+```json
+"ContainerIDFile": "",
+"LogConfig": {
+    "Type": "none",
+    "Config": {}
+}
+```
+
+This configuration meant:
+- No container logs were being captured
+- `docker logs <container>` would not work
+- Debugging container issues was difficult
+- The tool couldn't capture container output for analysis
+
+## Root Cause
+
+The issue was in the container creation code in two files:
+1. `app/agents/test_analysis_agent/docker_utils.py` - `build_container()` function
+2. `evaluation/docker_build.py` - `build_container()` and `build_setup_container()` functions
+
+These functions were creating containers without explicit logging configuration, causing Docker to use default settings that might be set to `"none"` in some environments.
+
+## Solution Applied
+
+I've updated all container creation calls to include proper logging configuration:
+
+### Before:
+```python
+container = client.containers.create(
+    image=test_image_name,
+    name=test_container_name,
+    user="root",
+    detach=True,
+    command="tail -f /dev/null",
+    nano_cpus=None,
+    platform="linux/x86_64",
+)
+```
+
+### After:
+```python
+container = client.containers.create(
+    image=test_image_name,
+    name=test_container_name,
+    user="root",
+    detach=True,
+    command="tail -f /dev/null",
+    nano_cpus=None,
+    platform="linux/x86_64",
+    log_config={
+        "Type": "json-file",
+        "Config": {
+            "max-size": "10m",
+            "max-file": "3"
+        }
+    }
+)
+```
+
+## Benefits of the Fix
+
+1. **Container Logs Available**: You can now use `docker logs <container>` to view container output
+2. **Better Debugging**: Container issues can be diagnosed more easily
+3. **Log Rotation**: Logs are automatically rotated when they reach 10MB
+4. **Storage Management**: Only 3 log files are kept per container
+5. **Tool Functionality**: The SWE Factory tool can now capture and analyze container output
+
+## Files Modified
+
+1. `app/agents/test_analysis_agent/docker_utils.py` - Line 330-340
+2. `evaluation/docker_build.py` - Lines 590-600 and 650-660
+
+## Testing the Fix
+
+After applying this fix, you should be able to:
+
+1. Run the SWE Factory tool as usual
+2. Use `docker logs <container_name>` to view container logs
+3. See container output in the tool's log files
+4. Debug container issues more effectively
+
+## Recommended Docker Configuration
+
+For optimal performance, ensure your Docker daemon is configured with:
+
+```json
+{
+  "log-driver": "json-file",
+  "log-opts": {
+    "max-size": "10m",
+    "max-file": "3"
+  }
+}
+```
+
+This ensures consistent logging behavior across all containers, even those created without explicit logging configuration. 

app/agents/test_analysis_agent/docker_utils.py

@@ -339,6 +339,13 @@ def build_container(client,test_image_name,test_container_name,instance_id,run_t
                 command="tail -f /dev/null",
                 nano_cpus=None,
                 platform="linux/x86_64",
+                log_config={
+                    "Type": "json-file",
+                    "Config": {
+                        "max-size": "10m",
+                        "max-file": "3"
+                    }
+                }
             )
 
 

app/globals.py

@@ -53,3 +53,6 @@
 disable_context_retrieval: bool = False
 
 disable_run_test: bool = False
+
+# whether to only organize output without running tasks
+organize_output_only: bool = False

app/main.py

@@ -77,6 +77,9 @@ def main(args, subparser_dest_attr_name: str = "command"):
     globals.output_dir = args.output_dir
     if globals.output_dir is not None:
         globals.output_dir = abspath(globals.output_dir)
+    else:
+        # Set a default output directory if none is provided
+        globals.output_dir = abspath("output/swe-factory-runs/default")
     num_processes: int = int(args.num_processes)
     # set whether brief or verbose log
     print_stdout: bool = not args.no_print
@@ -100,6 +103,11 @@ def main(args, subparser_dest_attr_name: str = "command"):
 
     globals.context_generation_limit = args.output_fix_limit
     globals.setup_dir = args.setup_dir 
+    if globals.setup_dir is not None:
+        globals.setup_dir = abspath(globals.setup_dir)
+    else:
+        # Set a default setup directory if none is provided
+        globals.setup_dir = abspath("output/swe-factory-runs/testbed")
 
     globals.organize_output_only = args.organize_output_only
     globals.results_path = args.results_path 
@@ -657,6 +665,11 @@ def run_raw_task(
 
     start_time_s = datetime.now().strftime("%Y-%m-%d_%H-%M-%S")
     # task_output_dir = pjoin(globals.output_dir, f"{task_id}_{start_time_s}")
+    
+    # Ensure globals.output_dir is set
+    if not globals.output_dir:
+        globals.output_dir = abspath("output/swe-factory-runs/default")
+    
     task_output_dir = pjoin(globals.output_dir, f"{task_id}")
 
     # Ensure task_output_dir is absolute
@@ -721,6 +734,10 @@ def do_inference(
     if hasattr(python_task, 'repo_cache_path'):
         repo_cache_path = python_task.repo_cache_path
     else:
+        # Ensure globals.setup_dir is set
+        if not globals.setup_dir:
+            globals.setup_dir = abspath("output/swe-factory-runs/testbed")
+        
         # Create a working directory in the testbed to avoid deleting the original repo
         working_dir = pjoin(globals.setup_dir, f"{python_task.project_path.split('/')[-1]}_working")
         repo_cache_path = python_task.project_path

evaluation/docker_build.py

@@ -603,6 +603,13 @@ def build_container(
             command="tail -f /dev/null",
             nano_cpus=nano_cpus,
             platform=test_spec.platform,
+            log_config={
+                "Type": "json-file",
+                "Config": {
+                    "max-size": "10m",
+                    "max-file": "3"
+                }
+            }
         )
 
         logger.info(f"Container for {test_spec.instance_id} created: {container.id}")
@@ -659,6 +666,13 @@ def build_setup_container(
             command="tail -f /dev/null",
             # nano_cpus=nano_cpus,
             platform=test_spec.platform,
+            log_config={
+                "Type": "json-file",
+                "Config": {
+                    "max-size": "10m",
+                    "max-file": "3"
+                }
+            }
         )
 
         logger.info(f"Container for {test_spec.instance_id} created: {container.id}")