CreakingHeartState tag and mechanism #2783
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tal5
requested changes
Oct 24, 2025
| // --> | ||
| tagProcessor.registerTag(ElementTag.class, "heart_state", (attribute, object) -> { | ||
| if (!(object.getBlockState().getBlockData() instanceof CreakingHeart heart)) { | ||
| Debug.echoError("The 'LocationTag.heart_state' tag can only be called on a creaking heart block."); |
| Debug.echoError("The 'LocationTag.heart_state' tag can only be called on a creaking heart block."); | ||
| return null; | ||
| } | ||
| return Utilities.enumlikeToElement(heart.getCreakingHeartState()); |
Member
There was a problem hiding this comment.
Can probably just be new ElementTag(state)? These methods do some extra stuff for legacy/cross-version compatibility, but aren't really needed for normal enum usage.
| }); | ||
|
|
||
| // <--[mechanism] | ||
| // @object LocationTag |
Member
There was a problem hiding this comment.
This seems to be operating on just the BlockData, is there any reason it's on LocationTag and not a MaterialTag property (maybe in MaterialTag.mode)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in the
heart_statetag and mechanism to control a creaking heart's state.Requested in https://discord.com/channels/315163488085475337/1429656035865530380