Fix jsonSerialize using $this where it shouldn't (zircote#1745)

Author: smallsung

phpstan-baseline.neon

@@ -24,18 +24,6 @@ parameters:
 			count: 1
 			path: src/Analysers/ReflectionAnalyser.php
 
-		-
-			message: '#^Access to an undefined property OpenApi\\Annotations\\AbstractAnnotation\:\:\$description\.$#'
-			identifier: property.notFound
-			count: 1
-			path: src/Annotations/AbstractAnnotation.php
-
-		-
-			message: '#^Access to an undefined property OpenApi\\Annotations\\AbstractAnnotation\:\:\$summary\.$#'
-			identifier: property.notFound
-			count: 1
-			path: src/Annotations/AbstractAnnotation.php
-
 		-
 			message: '#^Call to function property_exists\(\) with OpenApi\\Annotations\\AbstractAnnotation and ''_context'' will always evaluate to true\.$#'
 			identifier: function.alreadyNarrowedType

src/Annotations/AbstractAnnotation.php

@@ -354,10 +354,8 @@ public function jsonSerialize()
             $ref = ['$ref' => $data->ref];
             if ($this->_context->isVersion(OpenApi::VERSION_3_1_0)) {
                 foreach (['summary', 'description'] as $prop) {
-                    if (property_exists($this, $prop)) {
-                        if (!Generator::isDefault($this->{$prop})) {
-                            $ref[$prop] = $data->{$prop};
-                        }
+                    if (property_exists($data, $prop)) {
+                        $ref[$prop] = $data->{$prop};
                     }
                 }
             }
@@ -368,16 +366,11 @@ public function jsonSerialize()
                 } else {
                     $ref['nullable'] = $data->nullable;
                 }
-                unset($data->nullable);
+                unset($data->ref, $data->nullable);
 
                 // preserve other properties
-                foreach (get_object_vars($this) as $property => $value) {
-                    if ('_' === $property[0] || in_array($property, ['ref', 'nullable'])) {
-                        continue;
-                    }
-                    if (!Generator::isDefault($value)) {
-                        $ref[$property] = $value;
-                    }
+                foreach (get_object_vars($data) as $property => $value) {
+                    $ref[$property] = $value;
                 }
             }
             $data = (object) $ref;