Merge branch 'origin/main' (prioritizing local UI and audit fixes)

Author: DerekGooding

scripts/agentic_review.py

@@ -94,6 +94,11 @@ def run_ai_review(commands, assertions=None):
                 print("Performing metadata verification...")
                 metadata_pass = verify_metadata(metadata_path, assertions)
 
+            # Semantic Review (Collision Detection)
+            print("Performing semantic UI review...")
+            from semantic_review import semantic_review
+            semantic_pass = semantic_review(metadata_path)
+
             # Visual Regression Check
             baseline_path = "review/baseline.png"
             visual_pass = True
@@ -113,7 +118,7 @@ def run_ai_review(commands, assertions=None):
             if os.path.exists(metadata_path):
                 shutil.copy(metadata_path, "review/screenshot.json")
 
-            return metadata_pass and visual_pass
+            return metadata_pass and semantic_pass and visual_pass
 
     print("Review failed! Screenshot not found.")
     return False

scripts/button_state_audit.py

@@ -7,23 +7,57 @@ def compare_button_states(idle_path, hover_path):
         print("Missing screenshots for comparison.")
         return False
 
+    idle_meta = idle_path.replace(".png", ".json")
+    hover_meta = hover_path.replace(".png", ".json")
+    
+    if not os.path.exists(idle_meta) or not os.path.exists(hover_meta):
+        print("Missing metadata for comparison.")
+        return False
+
+    with open(idle_meta, "r") as f: m1 = json.load(f)
+    with open(hover_meta, "r") as f: m2 = json.load(f)
+    
     img1 = Image.open(idle_path).convert('RGB')
     img2 = Image.open(hover_path).convert('RGB')
 
-    # Calculate average brightness
-    avg1 = np.mean(np.array(img1))
-    avg2 = np.mean(np.array(img2))
+    # Identify the button that changed (the one being hovered)
+    # For now, we compare all buttons and find the one with the most change
+    # or look for a specific button if provided.
+    
+    print(f"Button State Audit (Metadata-Aware):")
 
-    print(f"Button State Audit:")
-    print(f"  Idle Brightness: {avg1:.2f}")
-    print(f"  Hover Brightness: {avg2:.2f}")
+    max_diff = -1
+    best_btn = None
 
-    # Hover should generally be brighter in our theme
-    if avg2 > avg1:
-        print(f"  [SUCCESS] Hover state detected (Brightness increased by {avg2-avg1:.2f})")
-        return True
+    for b in m1.get("Buttons", []):
+        bounds = b['Bounds']
+        box = (bounds['X'], bounds['Y'], bounds['X'] + bounds['Width'], bounds['Y'] + bounds['Height'])
+        
+        # Crop button area
+        crop1 = img1.crop(box)
+        crop2 = img2.crop(box)
+        
+        avg1 = np.mean(np.array(crop1))
+        avg2 = np.mean(np.array(crop2))
+        diff = abs(avg2 - avg1)
+        
+        if diff > max_diff:
+            max_diff = diff
+            best_btn = (b['Text'], avg1, avg2)
+            
+    if best_btn and max_diff > 5: # Threshold for hover effect
+        print(f"  Detected hover effect on '{best_btn[0]}':")
+        print(f"    Idle Brightness: {best_btn[1]:.2f}")
+        print(f"    Hover Brightness: {best_btn[2]:.2f}")
+        
+        if best_btn[2] > best_btn[1]:
+            print(f"    [SUCCESS] Hover state detected (Brightness increased by {max_diff:.2f})")
+            return True
+        else:
+            print(f"    [FAIL] Hover state did not increase brightness.")
+            return False
     else:
-        print(f"  [FAIL] No visual change detected between Idle and Hover states.")
+        print(f"  [FAIL] No significant visual change detected in any button bounding box.")
         return False
 
 if __name__ == "__main__":

scripts/update_screenshots.py

@@ -23,7 +23,7 @@
         "manifest:speck_of_matter",
         "update:10.0",
         "tab:Spire",
-        "wait:1.0",
+        "update:1.0",
         "screenshot:spire_flow"
     ],
     "world_map": [
@@ -32,7 +32,7 @@
         "manifest:familiar",
         "update:5.0",
         "tab:World",
-        "wait:1.0",
+        "update:1.0",
         "screenshot:world_map"
     ],
     "mixing_table": [
@@ -41,7 +41,7 @@
         "manifest:forge",
         "update:5.0",
         "tab:Spire",
-        "wait:1.0",
+        "update:1.0",
         "screenshot:mixing_table"
     ]
 }

test_collision.json

@@ -0,0 +1,26 @@
+{
+  "ScreenWidth": 1024,
+  "ScreenHeight": 768,
+  "Buttons": [
+    {
+      "Text": "Test1",
+      "Bounds": { "X": 100, "Y": 100, "Width": 50, "Height": 50 },
+      "Tab": "Void"
+    },
+    {
+      "Text": "Test2",
+      "Bounds": { "X": 120, "Y": 120, "Width": 50, "Height": 50 },
+      "Tab": "Void"
+    },
+    {
+        "Text": "OffScreen",
+        "Bounds": { "X": 1100, "Y": 100, "Width": 50, "Height": 50 },
+        "Tab": "Void"
+    },
+    {
+        "Text": "PanelCollision",
+        "Bounds": { "X": 20, "Y": 60, "Width": 50, "Height": 50 },
+        "Tab": "Void"
+    }
+  ]
+}