Wrap callback exceptions into single group

Author: tpoliaw

src/blueapi/core/event.py

@@ -78,12 +78,11 @@ def publish(self, event: E, correlation_id: str | None = None) -> None:
             correlation_id: An optional ID that may be used to correlate this
                 event with other events
         """
-
+        errs = []
         for callback in list(self._subscriptions.values()):
             try:
                 callback(event, correlation_id)
             except Exception as e:
-                LOGGER.error(
-                    f"Failed to send event {event} with {correlation_id=}",
-                    exc_info=e,
-                )
+                errs.append(e)
+        if errs:
+            raise ExceptionGroup(f"Error(s) publishing event: {event}", errs)

tests/unit_tests/core/test_event.py

@@ -86,9 +86,10 @@ def test_callback_exceptions_are_contained(publisher: EventPublisher[MyEvent]):
     publisher.subscribe(handler)
     publisher.subscribe(handler)
 
-    publisher.publish(event, c_id)
+    with pytest.RaisesGroup(ValueError):
+        publisher.publish(event, c_id)
 
-    # Both handlers should be called and the exception should not be raised from publish
+    # Both handlers should be called but the exception should still be raised
     handler.assert_has_calls([mock.call(event, c_id), mock.call(event, c_id)])