From 5101847a1c72e11d5727f41e05abccee0e9e05c2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Krist=C3=B3f=20Miskolczi?= Date: Thu, 18 Jul 2024 12:34:19 +0200 Subject: [PATCH] Log rate limits as info so they can be silenced --- controllers/dopplersecret_controller.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/controllers/dopplersecret_controller.go b/controllers/dopplersecret_controller.go index afea351..bf51134 100644 --- a/controllers/dopplersecret_controller.go +++ b/controllers/dopplersecret_controller.go @@ -113,7 +113,13 @@ func (r *DopplerSecretReconciler) Reconcile(ctx context.Context, req ctrl.Reques err = r.UpdateSecret(ctx, dopplerSecret) r.SetSecretsSyncReadyCondition(ctx, &dopplerSecret, err) if err != nil { - log.Error(err, "Unable to update dopplersecret") + logMsg := "Unable to update dopplersecret" + // log rate limits at info level so they can be told apart from other errors and silenced by setting log level to error + if errors.IsTooManyRequests(err) { + log.WithValues("error", err).Info(logMsg) + } else { + log.Error(err, logMsg) + } return ctrl.Result{ RequeueAfter: requeueAfter, }, nil