Skip to content

Commit af321b7

Browse files
authored
Merge pull request #83 from EOPF-Sample-Service/dev
Merge latest changes
2 parents 597b705 + 7922e9e commit af321b7

29 files changed

Lines changed: 6168 additions & 19296 deletions

.github/workflows/deploy.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ on:
66
push:
77
# Runs on pushes targeting the default branch
88
branches: [main]
9-
paths: ["notebooks/**"]
109
env:
1110
# `BASE_URL` determines the website is served from, including CSS & JS assets
1211
# You may need to change this to `BASE_URL: ''`
@@ -46,13 +45,14 @@ jobs:
4645
condarc: |
4746
channels:
4847
- conda-forge
48+
- name: Generate gallery
49+
run: python generate_gallery.py
4950
- name: Execute Jupyter Notebooks and Build HTML Assets
5051
run: myst build --html --execute
51-
working-directory: notebooks
5252
- name: Upload artifact
5353
uses: actions/upload-pages-artifact@v3
5454
with:
55-
path: "./notebooks/_build/html"
55+
path: "./_build/html"
5656
- name: Deploy to GitHub Pages
5757
id: deployment
5858
uses: actions/deploy-pages@v4

CONTRIBUTING.md

Lines changed: 21 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,12 @@ This document outlines the process for creating, reviewing, and publishing sampl
4646
- Used for managing dataset requirements and conversions (e.g., to Zarr format).
4747

4848
### 2. Notebook Development Workflow
49+
4950
#### 2.1 Issue Creation
5051

5152
For each notebook to be developed, create a new GitHub Issue in the eopf-sample-notebooks repository.
5253
The issue must include:
54+
5355
- A clear description of the notebook’s purpose and expected content.
5456
- Assignment of a responsible contributor.
5557

@@ -62,33 +64,43 @@ The assigned contributor must:
6264
3. Create a corresponding Issue in the `eopf-sample-data` repository listing the datasets to be prepared and converted to Zarr format.
6365

6466
#### 2.3 Notebook Implementation
65-
##### 2.3.1 Data Availability
67+
68+
##### 2.3.1 Data Availability
69+
6670
- Notebook development should begin after the necessary data is available in the required format (Zarr).
6771

68-
##### 2.3.2 Template Compliance
72+
##### 2.3.2 Template Compliance
73+
6974
- All notebooks must adhere to the [standardized template](https://github.com/EOPF-Sample-Service/eopf-sample-notebooks/blob/main/notebooks/template/template.ipynb).
7075
- The template ensures consistency in structure, formatting and metadata.
7176
- Contributors should refer to the existing notebooks available in the repository before starting implementation.
7277

73-
##### 2.3.3 Python Environment
78+
##### 2.3.3 Python Environment
79+
7480
If you are using Python libraries which are not yet available in the [conda environment available here](https://github.com/EOPF-Sample-Service/eopf-sample-notebooks/blob/main/environment.yml), add them in the `environment.yml` and test if the conda environment can be created successfully. If the environment has to be updated, please mention it in the [eopf-container-images](https://github.com/EOPF-Sample-Service/eopf-container-images) repository, so that the env available at https://jupyterhub.user.eopf.eodc.eu can also be updated and be ready to run the notebook.
7581

76-
##### 2.3.4 MyST Rendering
82+
##### 2.3.4 MyST Rendering
83+
7784
Each notebook needs to have an entry in the [myst.yml](https://github.com/EOPF-Sample-Service/eopf-sample-notebooks/blob/main/notebooks/myst.yml) configuration file if you want it to be rendered as an html page. Please add a new row for your notebook before submitting the PR.
7885

79-
##### 2.3.5 Submission
86+
##### 2.3.5 Submission
87+
8088
Once the implementation is complete:
89+
8190
- Run the formatting checks as mentioned above.
8291
- Submit a Pull Request (PR) against the `/dev` branch.
8392
- Reference the original issue in the PR description.
8493

8594
#### 2.4 Quality Assurance
95+
8696
##### 2.4.1. Automated Checks
97+
8798
- GitHub Actions are configured to run:
88-
- Code formatting checks.
89-
- Code quality tests.
99+
- Code formatting checks.
100+
- Code quality tests.
90101

91102
#### 2.5 Peer Review and Pre-Publication
103+
92104
After passing automated checks, the notebook will be reviewed by the team.
93105

94106
Once approved, the PR is merged into the `/dev` branch.
@@ -97,13 +109,14 @@ This triggers automatic deployment to the development preview site:
97109
https://dev-eopf-sample-notebooks.netlify.app/
98110

99111
The development site allows:
112+
100113
- Verification of notebook rendering.
101114
- Internal feedback and issue tracking.
102115

103116
#### 2.6 Final Publication
117+
104118
After all feedback have been addressed, merge the changes from the `/dev` branch into the `/main` branch.
105119
This publishes the notebook to the official GitHub Pages site:
106120
https://eopf-sample-service.github.io/eopf-sample-notebooks/
107121

108-
109122
We appreciate your contributions — happy coding! 🚀

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,4 @@ Please refer to the [Contributing Guideline](CONTRIBUTING.md)
1919
## STAC
2020

2121
Discover the available sample datasets using the STAC Browser:
22-
https://stac.browser.user.eopf.eodc.eu
22+
https://stac.browser.user.eopf.eodc.eu

environment.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ channels:
33
- conda-forge
44
dependencies:
55
- python=3.11
6-
- xarray=2024.11.0
6+
- xarray
77
- xarray-eopf
88
- folium
99
- graphviz
@@ -19,6 +19,9 @@ dependencies:
1919
- jupyterlab-myst
2020
- python-graphviz
2121
- pystac-client
22+
- zarr
23+
- tqdm
24+
- geopandas
25+
- dask
26+
- rioxarray
2227
- pip
23-
- pip:
24-
- eopf==2.5.5

eopf.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ project:
33
open_access: true
44
license:
55
content: CC-BY-4.0
6-
code: MIT
6+
code: Apache-2.0
77
site:
88
template: book-theme
99
options:

0 commit comments

Comments
 (0)